Video bug fix #1349
Merged
Video bug fix #1349
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
Codecov Report
@@ Coverage Diff @@
## main #1349 +/- ##
==========================================
- Coverage 92.34% 92.25% -0.09%
==========================================
Files 176 176
Lines 14140 14160 +20
==========================================
+ Hits 13057 13064 +7
- Misses 1083 1096 +13
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
AbhinavTuli
reviewed
Dec 2, 2021
aliubimov
reviewed
Dec 2, 2021
hub/core/compression.py
Outdated
| ) | ||
| nbytes = len(raw_video) | ||
| size = np.prod(shape) | ||
| if nbytes >= size: |
There was a problem hiding this comment.
Please aslo add some comments why this logic is here.
AbhinavTuli
reviewed
Dec 28, 2021
hub/api/tests/test_video.py
Outdated
| for i in range(10): | ||
| assert ds.video[i].numpy().shape == sample.shape # type: ignore | ||
| for path in video_paths[compression]: | ||
| ds.create_tensor("video", htype="video", sample_compression=compression) |
There was a problem hiding this comment.
wouldn't this create this tensor multiple times?
AbhinavTuli
approved these changes
Dec 28, 2021
aliubimov
approved these changes
Dec 28, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🚀 🚀 Pull Request
Checklist:
coverage-rateupChanges
Fill missing tail frames from floating precision with blank frames.