Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix info not getting updated across versions #1356

Merged
merged 4 commits into from
Dec 8, 2021
Merged

Fix info not getting updated across versions #1356

merged 4 commits into from
Dec 8, 2021

Conversation

AbhinavTuli
Copy link
Contributor

🚀 🚀 Pull Request

Checklist:

  • My code follows the style guidelines of this project and the Contributing document
  • I have commented my code, particularly in hard-to-understand areas
  • I have kept the coverage-rate up
  • I have performed a self-review of my own code and resolved any problems
  • I have checked to ensure there aren't any other open Pull Requests for the same change
  • I have described and made corresponding changes to the relevant documentation
  • New and existing unit tests pass locally with my changes

Changes

A bug with info not persisting across versions was found in #1355.
This PR fixes the issue.

@codecov
Copy link

codecov bot commented Nov 28, 2021

Codecov Report

Merging #1356 (bace5ff) into main (d64ad2e) will increase coverage by 0.06%.
The diff coverage is 98.86%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1356      +/-   ##
==========================================
+ Coverage   92.70%   92.77%   +0.06%     
==========================================
  Files         174      174              
  Lines       12669    12749      +80     
==========================================
+ Hits        11745    11828      +83     
+ Misses        924      921       -3     
Flag Coverage Δ
unittests 92.77% <98.86%> (+0.06%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
hub/util/version_control.py 96.23% <92.30%> (-1.01%) ⬇️
hub/core/dataset/dataset.py 93.96% <100.00%> (+0.02%) ⬆️
hub/core/version_control/test_version_control.py 99.85% <100.00%> (+0.01%) ⬆️
hub/core/storage/cachable.py 88.88% <0.00%> (-1.86%) ⬇️
hub/integrations/pytorch/dataset.py 93.11% <0.00%> (+1.61%) ⬆️
hub/integrations/tests/test_pytorch_dataloader.py 97.84% <0.00%> (+2.15%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d64ad2e...bace5ff. Read the comment docs.

@AbhinavTuli AbhinavTuli merged commit 8ca1a13 into main Dec 8, 2021
@AbhinavTuli AbhinavTuli deleted the fix/vc/info branch December 8, 2021 03:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants