Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AL-1587] Fix iteration slowdowns and import issue #1368

Merged
merged 3 commits into from
Dec 2, 2021
Merged

Conversation

AbhinavTuli
Copy link
Contributor

🚀 🚀 Pull Request

Checklist:

  • My code follows the style guidelines of this project and the Contributing document
  • I have commented my code, particularly in hard-to-understand areas
  • I have kept the coverage-rate up
  • I have performed a self-review of my own code and resolved any problems
  • I have checked to ensure there aren't any other open Pull Requests for the same change
  • I have described and made corresponding changes to the relevant documentation
  • New and existing unit tests pass locally with my changes

Changes

@AbhinavTuli AbhinavTuli changed the title Fix slowdowns and import issue [AL-1587] Fix iteration slowdowns and import issue Dec 2, 2021
@codecov
Copy link

codecov bot commented Dec 2, 2021

Codecov Report

Merging #1368 (0ccb6ab) into main (944e1b3) will decrease coverage by 0.01%.
The diff coverage is 100.00%.

❗ Current head 0ccb6ab differs from pull request most recent head 5a174a2. Consider uploading reports for the commit 5a174a2 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1368      +/-   ##
==========================================
- Coverage   92.70%   92.68%   -0.02%     
==========================================
  Files         173      173              
  Lines       12527    12526       -1     
==========================================
- Hits        11613    11610       -3     
- Misses        914      916       +2     
Flag Coverage Δ
unittests 92.68% <100.00%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
hub/util/version_control.py 97.23% <ø> (-0.06%) ⬇️
hub/core/dataset/dataset.py 93.84% <100.00%> (+0.04%) ⬆️
hub/core/lock.py 82.22% <0.00%> (-8.89%) ⬇️
hub/integrations/pytorch/dataset.py 93.11% <0.00%> (+1.61%) ⬆️
hub/integrations/tests/test_pytorch_dataloader.py 97.84% <0.00%> (+2.15%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 944e1b3...5a174a2. Read the comment docs.

@aliubimov aliubimov self-requested a review December 2, 2021 04:23
@AbhinavTuli AbhinavTuli merged commit fc9929e into main Dec 2, 2021
@AbhinavTuli AbhinavTuli deleted the fix/slowdown branch December 2, 2021 11:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants