Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

moved bugout token to a file for better CD support #1373

Merged

Conversation

gautamkrishnar
Copy link
Contributor

🚀 🚀 Pull Request

moved bugout token to a file for better CD support

Checklist:

  • My code follows the style guidelines of this project and the Contributing document
  • I have commented my code, particularly in hard-to-understand areas
  • I have kept the coverage-rate up
  • I have performed a self-review of my own code and resolved any problems
  • I have checked to ensure there aren't any other open Pull Requests for the same change
  • I have described and made corresponding changes to the relevant documentation
  • New and existing unit tests pass locally with my changes

Changes

moved bugout token to a file for better CD support

@gautamkrishnar gautamkrishnar added the trigger-test Label trigger to run tests on PRs label Dec 5, 2021
@activeloop-bot activeloop-bot removed the trigger-test Label trigger to run tests on PRs label Dec 5, 2021
@codecov
Copy link

codecov bot commented Dec 5, 2021

Codecov Report

Merging #1373 (bbf3968) into main (55151dd) will increase coverage by 0.04%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1373      +/-   ##
==========================================
+ Coverage   92.76%   92.81%   +0.04%     
==========================================
  Files         173      174       +1     
  Lines       12667    12669       +2     
==========================================
+ Hits        11751    11759       +8     
+ Misses        916      910       -6     
Flag Coverage Δ
unittests 92.81% <100.00%> (+0.04%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
hub/util/bugout_reporter.py 77.58% <100.00%> (+0.39%) ⬆️
hub/util/bugout_token.py 100.00% <100.00%> (ø)
hub/integrations/pytorch/dataset.py 93.11% <0.00%> (+1.61%) ⬆️
hub/integrations/tests/test_pytorch_dataloader.py 97.84% <0.00%> (+2.15%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 55151dd...bbf3968. Read the comment docs.

@farizrahman4u farizrahman4u added the trigger-test Label trigger to run tests on PRs label Dec 6, 2021
@activeloop-bot activeloop-bot removed the trigger-test Label trigger to run tests on PRs label Dec 6, 2021
@farizrahman4u farizrahman4u merged commit d64ad2e into activeloopai:main Dec 6, 2021
@gautamkrishnar gautamkrishnar deleted the feat/add-bugout-key-file branch December 6, 2021 13:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants