Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AL-1610] Json VC Info #1413

Merged
merged 10 commits into from
Dec 29, 2021
Merged

[AL-1610] Json VC Info #1413

merged 10 commits into from
Dec 29, 2021

Conversation

farizrahman4u
Copy link
Contributor

🚀 🚀 Pull Request

Checklist:

  • My code follows the style guidelines of this project and the Contributing document
  • I have commented my code, particularly in hard-to-understand areas
  • I have kept the coverage-rate up
  • I have performed a self-review of my own code and resolved any problems
  • I have checked to ensure there aren't any other open Pull Requests for the same change
  • I have described and made corresponding changes to the relevant documentation
  • New and existing unit tests pass locally with my changes

Changes

@CLAassistant
Copy link

CLAassistant commented Dec 27, 2021

CLA assistant check
All committers have signed the CLA.

@farizrahman4u farizrahman4u marked this pull request as ready for review December 27, 2021 13:06
Copy link
Contributor

@AbhinavTuli AbhinavTuli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Would like to see unit tests for to_json and from_json

@codecov
Copy link

codecov bot commented Dec 28, 2021

Codecov Report

Merging #1413 (696581f) into main (2e815f9) will decrease coverage by 0.00%.
The diff coverage is 98.24%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1413      +/-   ##
==========================================
- Coverage   92.34%   92.33%   -0.01%     
==========================================
  Files         176      176              
  Lines       14140    14204      +64     
==========================================
+ Hits        13057    13115      +58     
- Misses       1083     1089       +6     
Flag Coverage Δ
unittests 92.33% <98.24%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
hub/core/version_control/test_version_control.py 99.86% <ø> (ø)
hub/util/version_control.py 98.00% <97.36%> (-0.12%) ⬇️
hub/constants.py 100.00% <100.00%> (ø)
hub/core/dataset/dataset.py 93.77% <100.00%> (ø)
hub/util/keys.py 100.00% <100.00%> (ø)
hub/util/tests/test_version_control.py 100.00% <100.00%> (ø)
hub/integrations/tests/test_pytorch_dataloader.py 95.69% <0.00%> (-2.16%) ⬇️
hub/integrations/pytorch/dataset.py 91.49% <0.00%> (-1.19%) ⬇️
hub/core/ipc.py 0.00% <0.00%> (ø)
hub/core/compression.py 89.60% <0.00%> (+0.09%) ⬆️
... and 6 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2e815f9...696581f. Read the comment docs.

@farizrahman4u farizrahman4u merged commit 5662c3a into main Dec 29, 2021
@farizrahman4u farizrahman4u deleted the fr_vc_info_json branch December 29, 2021 12:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants