-
Notifications
You must be signed in to change notification settings - Fork 625
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[AL-1610] Json VC Info #1413
[AL-1610] Json VC Info #1413
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Would like to see unit tests for to_json and from_json
Codecov Report
@@ Coverage Diff @@
## main #1413 +/- ##
==========================================
- Coverage 92.34% 92.33% -0.01%
==========================================
Files 176 176
Lines 14140 14204 +64
==========================================
+ Hits 13057 13115 +58
- Misses 1083 1089 +6
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
🚀 🚀 Pull Request
Checklist:
coverage-rate
upChanges