Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix windows pickling issue #1421

Merged
merged 3 commits into from
Dec 29, 2021
Merged

Fix windows pickling issue #1421

merged 3 commits into from
Dec 29, 2021

Conversation

farizrahman4u
Copy link
Contributor

🚀 🚀 Pull Request

Checklist:

  • My code follows the style guidelines of this project and the Contributing document
  • I have commented my code, particularly in hard-to-understand areas
  • I have kept the coverage-rate up
  • I have performed a self-review of my own code and resolved any problems
  • I have checked to ensure there aren't any other open Pull Requests for the same change
  • I have described and made corresponding changes to the relevant documentation
  • New and existing unit tests pass locally with my changes

Changes

@CLAassistant
Copy link

CLAassistant commented Dec 29, 2021

CLA assistant check
All committers have signed the CLA.

@codecov
Copy link

codecov bot commented Dec 29, 2021

Codecov Report

Merging #1421 (dd58faf) into main (5662c3a) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1421   +/-   ##
=======================================
  Coverage   92.33%   92.33%           
=======================================
  Files         176      176           
  Lines       14204    14205    +1     
=======================================
+ Hits        13115    13116    +1     
  Misses       1089     1089           
Flag Coverage Δ
unittests 92.33% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
hub/core/dataset/dataset.py 93.78% <100.00%> (+0.01%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5662c3a...dd58faf. Read the comment docs.

@farizrahman4u farizrahman4u merged commit a691c97 into main Dec 29, 2021
@farizrahman4u farizrahman4u deleted the fr_fix_windows_pickling branch December 29, 2021 20:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants