Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix indexing and groups #1426

Merged
merged 2 commits into from
Jan 14, 2022
Merged

Fix indexing and groups #1426

merged 2 commits into from
Jan 14, 2022

Conversation

aliubimov
Copy link
Contributor

No description provided.

@aliubimov aliubimov added the trigger-test Label trigger to run tests on PRs label Dec 31, 2021
@activeloop-bot activeloop-bot removed the trigger-test Label trigger to run tests on PRs label Dec 31, 2021
@codecov
Copy link

codecov bot commented Dec 31, 2021

Codecov Report

Merging #1426 (6130dcf) into main (6cf888b) will increase coverage by 0.14%.
The diff coverage is 95.65%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1426      +/-   ##
==========================================
+ Coverage   92.00%   92.14%   +0.14%     
==========================================
  Files         175      175              
  Lines       14169    14189      +20     
==========================================
+ Hits        13036    13075      +39     
+ Misses       1133     1114      -19     
Flag Coverage Δ
unittests 92.14% <95.65%> (+0.14%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
hub/core/query/filter.py 61.76% <93.33%> (+3.70%) ⬆️
hub/core/query/query.py 85.61% <95.00%> (+9.06%) ⬆️
hub/core/compute/provider.py 97.29% <100.00%> (ø)
hub/core/query/test/test_query.py 100.00% <100.00%> (ø)
hub/integrations/pytorch/dataset.py 92.91% <0.00%> (+1.57%) ⬆️
hub/integrations/tests/test_pytorch_dataloader.py 97.84% <0.00%> (+2.15%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6cf888b...6130dcf. Read the comment docs.

@aliubimov aliubimov added the trigger-test Label trigger to run tests on PRs label Jan 13, 2022
@activeloop-bot activeloop-bot removed the trigger-test Label trigger to run tests on PRs label Jan 13, 2022
@aliubimov aliubimov added the trigger-test Label trigger to run tests on PRs label Jan 13, 2022
@activeloop-bot activeloop-bot removed the trigger-test Label trigger to run tests on PRs label Jan 13, 2022
@aliubimov aliubimov merged commit 79559f4 into activeloopai:main Jan 14, 2022
@aliubimov aliubimov deleted the fix/query/twice branch January 14, 2022 20:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants