Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove explicit shared memory conversion #1437

Merged
merged 1 commit into from
Jan 14, 2022
Merged

Remove explicit shared memory conversion #1437

merged 1 commit into from
Jan 14, 2022

Conversation

aliubimov
Copy link
Contributor

No description provided.

@aliubimov aliubimov added the trigger-test Label trigger to run tests on PRs label Jan 13, 2022
@activeloop-bot activeloop-bot removed the trigger-test Label trigger to run tests on PRs label Jan 13, 2022
@codecov
Copy link

codecov bot commented Jan 13, 2022

Codecov Report

Merging #1437 (9c7cbe9) into main (6d4693d) will increase coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1437      +/-   ##
==========================================
+ Coverage   92.01%   92.03%   +0.01%     
==========================================
  Files         175      175              
  Lines       14067    14067              
==========================================
+ Hits        12944    12946       +2     
+ Misses       1123     1121       -2     
Flag Coverage Δ
unittests 92.03% <100.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
hub/integrations/pytorch/dataset.py 93.11% <100.00%> (+1.61%) ⬆️
hub/util/storage.py 92.98% <0.00%> (-3.51%) ⬇️
hub/core/chunk_engine.py 94.86% <0.00%> (-0.36%) ⬇️
hub/integrations/tests/test_pytorch_dataloader.py 97.84% <0.00%> (+2.15%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6d4693d...9c7cbe9. Read the comment docs.

Copy link
Contributor

@jraman jraman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please attach a JIRA ticket to this PR.

@aliubimov aliubimov merged commit 6d3dd95 into activeloopai:main Jan 14, 2022
@aliubimov aliubimov deleted the fix/torch branch January 14, 2022 02:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants