Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AL-1626] Speedup hub load #1442

Merged
merged 6 commits into from
Jan 21, 2022
Merged

[AL-1626] Speedup hub load #1442

merged 6 commits into from
Jan 21, 2022

Conversation

AbhinavTuli
Copy link
Contributor

@AbhinavTuli AbhinavTuli commented Jan 17, 2022

🚀 🚀 Pull Request

Checklist:

  • My code follows the style guidelines of this project and the Contributing document
  • I have commented my code, particularly in hard-to-understand areas
  • I have kept the coverage-rate up
  • I have performed a self-review of my own code and resolved any problems
  • I have checked to ensure there aren't any other open Pull Requests for the same change
  • I have described and made corresponding changes to the relevant documentation
  • New and existing unit tests pass locally with my changes

Changes

  • Removes redundant loads of dataset meta from storage

@codecov
Copy link

codecov bot commented Jan 21, 2022

Codecov Report

Merging #1442 (88ca7ad) into main (c1130de) will increase coverage by 0.03%.
The diff coverage is 97.05%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1442      +/-   ##
==========================================
+ Coverage   92.10%   92.13%   +0.03%     
==========================================
  Files         178      178              
  Lines       14325    14323       -2     
==========================================
+ Hits        13194    13197       +3     
+ Misses       1131     1126       -5     
Flag Coverage Δ
unittests 92.13% <97.05%> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
hub/api/dataset.py 87.71% <83.33%> (ø)
hub/core/dataset/dataset.py 93.77% <100.00%> (-0.03%) ⬇️
hub/util/version_control.py 98.00% <100.00%> (ø)
hub/core/lock.py 85.24% <0.00%> (+1.63%) ⬆️
hub/core/storage/s3.py 73.59% <0.00%> (+1.68%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c1130de...88ca7ad. Read the comment docs.

@AbhinavTuli AbhinavTuli merged commit e5be11f into main Jan 21, 2022
@AbhinavTuli AbhinavTuli deleted the speedup/load branch January 21, 2022 10:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants