Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix wrong video shape #1447

Merged
merged 1 commit into from
Jan 20, 2022
Merged

Conversation

FayazRahman
Copy link
Contributor

@FayazRahman FayazRahman commented Jan 19, 2022

🚀 🚀 Pull Request

Checklist:

  • My code follows the style guidelines of this project and the Contributing document
  • I have commented my code, particularly in hard-to-understand areas
  • I have kept the coverage-rate up
  • I have performed a self-review of my own code and resolved any problems
  • I have checked to ensure there aren't any other open Pull Requests for the same change
  • I have described and made corresponding changes to the relevant documentation
  • New and existing unit tests pass locally with my changes

Changes

Replace r_frame_rate with avg_frame_rate
Fixes #1433

@CLAassistant
Copy link

CLAassistant commented Jan 19, 2022

CLA assistant check
All committers have signed the CLA.

@aliubimov aliubimov added the trigger-test Label trigger to run tests on PRs label Jan 19, 2022
@activeloop-bot activeloop-bot removed the trigger-test Label trigger to run tests on PRs label Jan 19, 2022
@codecov
Copy link

codecov bot commented Jan 19, 2022

Codecov Report

Merging #1447 (cbba6bb) into main (1328034) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1447   +/-   ##
=======================================
  Coverage   92.18%   92.18%           
=======================================
  Files         178      178           
  Lines       14325    14325           
=======================================
  Hits        13205    13205           
  Misses       1120     1120           
Flag Coverage Δ
unittests 92.18% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
hub/core/compression.py 89.25% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1328034...cbba6bb. Read the comment docs.

@FayazRahman FayazRahman added the trigger-test Label trigger to run tests on PRs label Jan 20, 2022
@activeloop-bot activeloop-bot removed the trigger-test Label trigger to run tests on PRs label Jan 20, 2022
@FayazRahman FayazRahman merged commit c1130de into activeloopai:main Jan 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] hub.read failing with h265 videos
5 participants