Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AL-1672] Add profile_name to creds argument #1450

Merged
merged 10 commits into from
Jan 28, 2022
Merged

[AL-1672] Add profile_name to creds argument #1450

merged 10 commits into from
Jan 28, 2022

Conversation

AbhinavTuli
Copy link
Contributor

🚀 🚀 Pull Request

Checklist:

  • My code follows the style guidelines of this project and the Contributing document
  • I have commented my code, particularly in hard-to-understand areas
  • I have kept the coverage-rate up
  • I have performed a self-review of my own code and resolved any problems
  • I have checked to ensure there aren't any other open Pull Requests for the same change
  • I have described and made corresponding changes to the relevant documentation
  • New and existing unit tests pass locally with my changes

Changes

@codecov
Copy link

codecov bot commented Jan 21, 2022

Codecov Report

Merging #1450 (6593ee8) into main (b74da96) will decrease coverage by 0.04%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1450      +/-   ##
==========================================
- Coverage   91.20%   91.15%   -0.05%     
==========================================
  Files         179      179              
  Lines       14550    14545       -5     
==========================================
- Hits        13270    13259      -11     
- Misses       1280     1286       +6     
Flag Coverage Δ
unittests 91.15% <100.00%> (-0.05%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
hub/api/dataset.py 87.71% <ø> (ø)
hub/core/storage/s3.py 71.18% <100.00%> (-0.95%) ⬇️
hub/util/storage.py 96.55% <100.00%> (+3.56%) ⬆️
hub/core/lock.py 85.24% <0.00%> (-6.56%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b74da96...6593ee8. Read the comment docs.

Copy link
Member

@davidbuniat davidbuniat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please move S3 profile into creds, I don’t think it should be a separate argument for the end user

Copy link
Contributor

@farizrahman4u farizrahman4u left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure about adding storage specific srgs to core dataset and api.

@AbhinavTuli AbhinavTuli changed the title [AL-1672] Add s3 profile argument to dataset [AL-1672] Add profile_name to creds argument Jan 26, 2022
@tatevikh tatevikh requested a review from jraman January 27, 2022 04:02
hub/api/dataset.py Outdated Show resolved Hide resolved
hub/core/storage/s3.py Outdated Show resolved Hide resolved
hub/core/storage/s3.py Show resolved Hide resolved
@AbhinavTuli AbhinavTuli merged commit fbb1f97 into main Jan 28, 2022
@AbhinavTuli AbhinavTuli deleted the s3/profile branch January 28, 2022 15:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants