-
Notifications
You must be signed in to change notification settings - Fork 625
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[AL-1672] Add profile_name to creds argument #1450
Conversation
Codecov Report
@@ Coverage Diff @@
## main #1450 +/- ##
==========================================
- Coverage 91.20% 91.15% -0.05%
==========================================
Files 179 179
Lines 14550 14545 -5
==========================================
- Hits 13270 13259 -11
- Misses 1280 1286 +6
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please move S3 profile into creds, I don’t think it should be a separate argument for the end user
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure about adding storage specific srgs to core dataset and api.
🚀 🚀 Pull Request
Checklist:
coverage-rate
upChanges