Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename from_huggingface to ingest_huggingface #1454

Merged
merged 1 commit into from
Jan 27, 2022

Conversation

FayazRahman
Copy link
Contributor

@FayazRahman FayazRahman commented Jan 24, 2022

🚀 🚀 Pull Request

Checklist:

  • My code follows the style guidelines of this project and the Contributing document
  • I have commented my code, particularly in hard-to-understand areas
  • I have kept the coverage-rate up
  • I have performed a self-review of my own code and resolved any problems
  • I have checked to ensure there aren't any other open Pull Requests for the same change
  • I have described and made corresponding changes to the relevant documentation
  • New and existing unit tests pass locally with my changes

Changes

Rename from_huggingface to ingest_huggingface

@FayazRahman FayazRahman added the trigger-test Label trigger to run tests on PRs label Jan 24, 2022
@activeloop-bot activeloop-bot removed the trigger-test Label trigger to run tests on PRs label Jan 24, 2022
@codecov
Copy link

codecov bot commented Jan 24, 2022

Codecov Report

Merging #1454 (b964c96) into main (abc19ec) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1454   +/-   ##
=======================================
  Coverage   91.80%   91.81%           
=======================================
  Files         178      178           
  Lines       14515    14518    +3     
=======================================
+ Hits        13326    13329    +3     
  Misses       1189     1189           
Flag Coverage Δ
unittests 91.81% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
hub/__init__.py 97.87% <100.00%> (+0.09%) ⬆️
hub/integrations/huggingface/__init__.py 100.00% <100.00%> (ø)
hub/integrations/huggingface/huggingface.py 88.70% <100.00%> (ø)
hub/integrations/tests/test_huggingface.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update abc19ec...b964c96. Read the comment docs.

@AbhinavTuli AbhinavTuli merged commit b74da96 into activeloopai:main Jan 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants