Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delete hub cloud datasets properly in tests #1494

Merged
merged 1 commit into from
Feb 16, 2022
Merged

Conversation

AbhinavTuli
Copy link
Contributor

🚀 🚀 Pull Request

Checklist:

  • My code follows the style guidelines of this project and the Contributing document
  • I have commented my code, particularly in hard-to-understand areas
  • I have kept the coverage-rate up
  • I have performed a self-review of my own code and resolved any problems
  • I have checked to ensure there aren't any other open Pull Requests for the same change
  • I have described and made corresponding changes to the relevant documentation
  • New and existing unit tests pass locally with my changes

Changes

@codecov
Copy link

codecov bot commented Feb 16, 2022

Codecov Report

Merging #1494 (97d00be) into main (d34ca60) will increase coverage by 0.70%.
The diff coverage is 97.06%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1494      +/-   ##
==========================================
+ Coverage   91.14%   91.85%   +0.70%     
==========================================
  Files         185      185              
  Lines       15282    15903     +621     
==========================================
+ Hits        13929    14607     +678     
+ Misses       1353     1296      -57     
Flag Coverage Δ
unittests 91.85% <97.06%> (+0.70%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
hub/core/fast_forwarding.py 67.24% <0.00%> (+0.57%) ⬆️
hub/core/tiling/sample_tiles.py 100.00% <ø> (ø)
hub/core/tiling/serialize.py 100.00% <ø> (ø)
hub/util/cache_chain.py 84.37% <ø> (ø)
hub/core/query/query.py 84.88% <87.50%> (+2.19%) ⬆️
hub/core/sample.py 88.93% <92.06%> (+1.13%) ⬆️
hub/util/version_control.py 98.50% <94.11%> (+0.45%) ⬆️
hub/util/transform.py 92.50% <94.44%> (+0.42%) ⬆️
hub/util/diff.py 95.71% <95.37%> (-0.74%) ⬇️
hub/core/storage/hub_memory_object.py 95.83% <95.83%> (ø)
... and 91 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2ec75a1...97d00be. Read the comment docs.

@AbhinavTuli AbhinavTuli merged commit f130785 into main Feb 16, 2022
@AbhinavTuli AbhinavTuli deleted the fix/hub_cloud_deletion branch February 16, 2022 17:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants