Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix hub compute + filter #1504

Merged
merged 2 commits into from
Feb 21, 2022
Merged

Fix hub compute + filter #1504

merged 2 commits into from
Feb 21, 2022

Conversation

AbhinavTuli
Copy link
Contributor

🚀 🚀 Pull Request

Checklist:

  • My code follows the style guidelines of this project and the Contributing document
  • I have commented my code, particularly in hard-to-understand areas
  • I have kept the coverage-rate up
  • I have performed a self-review of my own code and resolved any problems
  • I have checked to ensure there aren't any other open Pull Requests for the same change
  • I have described and made corresponding changes to the relevant documentation
  • New and existing unit tests pass locally with my changes

Changes

@codecov
Copy link

codecov bot commented Feb 21, 2022

Codecov Report

Merging #1504 (fd1b86b) into main (d97a616) will decrease coverage by 0.49%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1504      +/-   ##
==========================================
- Coverage   92.11%   91.62%   -0.50%     
==========================================
  Files         184      184              
  Lines       16062    15861     -201     
==========================================
- Hits        14795    14532     -263     
- Misses       1267     1329      +62     
Flag Coverage Δ
unittests 91.62% <100.00%> (-0.50%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
hub/core/query/filter.py 87.74% <100.00%> (+1.58%) ⬆️
hub/core/query/test/test_query.py 100.00% <100.00%> (ø)
hub/api/tests/test_api_with_compression.py 89.78% <0.00%> (-10.22%) ⬇️
hub/core/tests/test_compression.py 94.49% <0.00%> (-5.51%) ⬇️
hub/tests/path_fixtures.py 87.30% <0.00%> (-3.39%) ⬇️
hub/core/lock.py 83.68% <0.00%> (-2.84%) ⬇️
hub/core/compression.py 85.34% <0.00%> (-2.60%) ⬇️
hub/integrations/tests/test_pytorch_dataloader.py 95.34% <0.00%> (-2.51%) ⬇️
hub/core/fast_forwarding.py 64.81% <0.00%> (-2.43%) ⬇️
hub/tests/storage_fixtures.py 87.87% <0.00%> (-2.37%) ⬇️
... and 52 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d97a616...fd1b86b. Read the comment docs.

@AbhinavTuli AbhinavTuli merged commit dd0c6c0 into main Feb 21, 2022
@AbhinavTuli AbhinavTuli deleted the fix/filter_compute branch February 21, 2022 13:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants