Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug Fix] Fixes an issue with info not being updated properly outside with context #1515

Merged
merged 2 commits into from
Mar 1, 2022

Conversation

AbhinavTuli
Copy link
Contributor

🚀 🚀 Pull Request

Checklist:

  • My code follows the style guidelines of this project and the Contributing document
  • I have commented my code, particularly in hard-to-understand areas
  • I have kept the coverage-rate up
  • I have performed a self-review of my own code and resolved any problems
  • I have checked to ensure there aren't any other open Pull Requests for the same change
  • I have described and made corresponding changes to the relevant documentation
  • New and existing unit tests pass locally with my changes

Changes

@codecov
Copy link

codecov bot commented Mar 1, 2022

Codecov Report

Merging #1515 (ba002b0) into main (8b44a01) will decrease coverage by 0.09%.
The diff coverage is 100.00%.

❗ Current head ba002b0 differs from pull request most recent head ce5f865. Consider uploading reports for the commit ce5f865 to get more accurate results

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1515      +/-   ##
==========================================
- Coverage   92.29%   92.20%   -0.10%     
==========================================
  Files         185      185              
  Lines       16240    16227      -13     
==========================================
- Hits        14989    14962      -27     
- Misses       1251     1265      +14     
Flag Coverage Δ
unittests 92.20% <100.00%> (-0.10%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
hub/api/info.py 86.99% <100.00%> (ø)
hub/core/lock.py 88.57% <0.00%> (-5.76%) ⬇️
hub/core/compute/provider.py 94.44% <0.00%> (-2.86%) ⬇️
hub/integrations/tests/test_pytorch_dataloader.py 95.69% <0.00%> (-2.16%) ⬇️
hub/core/query/autocomplete.py 79.54% <0.00%> (-1.71%) ⬇️
hub/integrations/pytorch/dataset.py 91.30% <0.00%> (-1.61%) ⬇️
hub/core/meta/encode/chunk_id.py 96.06% <0.00%> (-0.79%) ⬇️
hub/tests/path_fixtures.py 90.23% <0.00%> (-0.47%) ⬇️
hub/core/dataset/dataset.py 92.98% <0.00%> (-0.42%) ⬇️
hub/util/exceptions.py 80.06% <0.00%> (-0.34%) ⬇️
... and 5 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8b44a01...ce5f865. Read the comment docs.

@AbhinavTuli AbhinavTuli merged commit 1f8b958 into main Mar 1, 2022
@AbhinavTuli AbhinavTuli deleted the fix/info_bug branch March 1, 2022 08:46
levongh pushed a commit to levongh/Hub that referenced this pull request Mar 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants