Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] Fix memory leak #1523

Merged
merged 1 commit into from
Mar 5, 2022
Merged

[Bug] Fix memory leak #1523

merged 1 commit into from
Mar 5, 2022

Conversation

AbhinavTuli
Copy link
Contributor

🚀 🚀 Pull Request

Checklist:

  • My code follows the style guidelines of this project and the Contributing document
  • I have commented my code, particularly in hard-to-understand areas
  • I have kept the coverage-rate up
  • I have performed a self-review of my own code and resolved any problems
  • I have checked to ensure there aren't any other open Pull Requests for the same change
  • I have described and made corresponding changes to the relevant documentation
  • New and existing unit tests pass locally with my changes

Changes

@@ -396,7 +396,7 @@ def active_appended_chunk(self):
@active_appended_chunk.setter
def active_appended_chunk(self, value):
if self.active_appended_chunk is not None:
self.cache.remove_hub_object(self.active_appended_chunk)
self.cache.remove_hub_object(self.active_appended_chunk.key)
Copy link
Contributor Author

@AbhinavTuli AbhinavTuli Mar 5, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this method needed the chunk key, instead the Chunk object was being passed

@codecov
Copy link

codecov bot commented Mar 5, 2022

Codecov Report

Merging #1523 (af445a6) into main (6ef9381) will decrease coverage by 0.44%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1523      +/-   ##
==========================================
- Coverage   92.35%   91.90%   -0.45%     
==========================================
  Files         189      189              
  Lines       16453    16235     -218     
==========================================
- Hits        15195    14921     -274     
- Misses       1258     1314      +56     
Flag Coverage Δ
unittests 91.90% <100.00%> (-0.45%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
hub/core/chunk_engine.py 95.56% <100.00%> (+0.24%) ⬆️
hub/api/tests/test_api_with_compression.py 89.78% <0.00%> (-10.22%) ⬇️
hub/core/tests/test_compression.py 94.49% <0.00%> (-5.51%) ⬇️
hub/tests/path_fixtures.py 87.30% <0.00%> (-3.39%) ⬇️
hub/core/compression.py 85.19% <0.00%> (-2.56%) ⬇️
hub/core/fast_forwarding.py 64.81% <0.00%> (-2.43%) ⬇️
hub/tests/storage_fixtures.py 87.87% <0.00%> (-2.37%) ⬇️
hub/api/tests/test_api.py 97.89% <0.00%> (-2.11%) ⬇️
hub/core/meta/tensor_meta.py 85.94% <0.00%> (-1.69%) ⬇️
hub/tests/client_fixtures.py 82.75% <0.00%> (-1.62%) ⬇️
... and 51 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6ef9381...af445a6. Read the comment docs.

@AbhinavTuli AbhinavTuli merged commit 364ce3a into main Mar 5, 2022
@AbhinavTuli AbhinavTuli deleted the fix/new_mem_leak branch March 5, 2022 14:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants