Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix TF requirement when installing hub #1542

Merged
merged 4 commits into from
Mar 15, 2022
Merged

Fix TF requirement when installing hub #1542

merged 4 commits into from
Mar 15, 2022

Conversation

farizrahman4u
Copy link
Contributor

🚀 🚀 Pull Request

Checklist:

  • My code follows the style guidelines of this project and the Contributing document
  • I have commented my code, particularly in hard-to-understand areas
  • I have kept the coverage-rate up
  • I have performed a self-review of my own code and resolved any problems
  • I have checked to ensure there aren't any other open Pull Requests for the same change
  • I have described and made corresponding changes to the relevant documentation
  • New and existing unit tests pass locally with my changes

Changes

@codecov
Copy link

codecov bot commented Mar 14, 2022

Codecov Report

Merging #1542 (7d03a63) into main (1c8784c) will increase coverage by 0.49%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1542      +/-   ##
==========================================
+ Coverage   91.72%   92.21%   +0.49%     
==========================================
  Files         193      193              
  Lines       16879    17135     +256     
==========================================
+ Hits        15482    15801     +319     
+ Misses       1397     1334      -63     
Flag Coverage Δ
unittests 92.21% <100.00%> (+0.49%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
hub/integrations/tf/datasettotensorflow.py 59.37% <100.00%> (ø)
conftest.py 100.00% <0.00%> (ø)
hub/cli/commands.py 100.00% <0.00%> (ø)
hub/api/tests/test_json.py 100.00% <0.00%> (ø)
hub/api/tests/test_text.py 100.00% <0.00%> (ø)
hub/tests/cache_fixtures.py 100.00% <0.00%> (ø)
hub/api/tests/test_events.py 100.00% <0.00%> (ø)
hub/api/tests/test_pickle.py 100.00% <0.00%> (ø)
hub/core/storage/provider.py 100.00% <0.00%> (ø)
hub/core/meta/dataset_meta.py 100.00% <0.00%> (ø)
... and 52 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1c8784c...7d03a63. Read the comment docs.

@FayazRahman FayazRahman merged commit 2893b40 into main Mar 15, 2022
@FayazRahman FayazRahman deleted the fr_fix_tf_req branch March 15, 2022 05:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants