Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes shuffle + collate #1552

Merged
merged 8 commits into from
Mar 28, 2022
Merged

Fixes shuffle + collate #1552

merged 8 commits into from
Mar 28, 2022

Conversation

AbhinavTuli
Copy link
Contributor

@AbhinavTuli AbhinavTuli commented Mar 16, 2022

🚀 🚀 Pull Request

Checklist:

  • My code follows the style guidelines of this project and the Contributing document
  • I have commented my code, particularly in hard-to-understand areas
  • I have kept the coverage-rate up
  • I have performed a self-review of my own code and resolved any problems
  • I have checked to ensure there aren't any other open Pull Requests for the same change
  • I have described and made corresponding changes to the relevant documentation
  • New and existing unit tests pass locally with my changes

Changes

In case of shuffled dataloader, we were collating twice, leading to issues. This fixes it.

@codecov
Copy link

codecov bot commented Mar 16, 2022

Codecov Report

Merging #1552 (a4ca7c3) into main (ff63116) will decrease coverage by 0.04%.
The diff coverage is 74.50%.

@@            Coverage Diff             @@
##             main    #1552      +/-   ##
==========================================
- Coverage   92.48%   92.44%   -0.05%     
==========================================
  Files         200      200              
  Lines       18228    18265      +37     
==========================================
+ Hits        16859    16885      +26     
- Misses       1369     1380      +11     
Flag Coverage Δ
unittests 92.44% <74.50%> (-0.05%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
hub/integrations/pytorch/pytorch.py 86.66% <ø> (ø)
hub/integrations/tests/test_pytorch_dataloader.py 95.69% <ø> (ø)
hub/integrations/pytorch/dataset.py 89.05% <59.09%> (-2.32%) ⬇️
hub/integrations/pytorch/shuffle_buffer.py 89.13% <60.00%> (-3.90%) ⬇️
hub/integrations/tests/test_pytorch.py 99.46% <91.66%> (-0.54%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ff63116...a4ca7c3. Read the comment docs.

@AbhinavTuli AbhinavTuli merged commit e6023fe into main Mar 28, 2022
@AbhinavTuli AbhinavTuli deleted the fix/shuffle_collate branch March 28, 2022 13:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants