Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[AL-1749] image.rgb and image.gray htypes #1646

Merged
merged 7 commits into from
May 9, 2022
Merged

[AL-1749] image.rgb and image.gray htypes #1646

merged 7 commits into from
May 9, 2022

Conversation

FayazRahman
Copy link
Contributor

🚀 🚀 Pull Request

Checklist:

  • My code follows the style guidelines of this project and the Contributing document
  • I have commented my code, particularly in hard-to-understand areas
  • I have kept the coverage-rate up
  • I have performed a self-review of my own code and resolved any problems
  • I have checked to ensure there aren't any other open Pull Requests for the same change
  • I have described and made corresponding changes to the relevant documentation
  • New and existing unit tests pass locally with my changes

Changes

Added new htypes image.rgb and image.gray

@tatevikh tatevikh changed the title image.rgb and image.gray htypes [AL-1749] image.rgb and image.gray htypes May 5, 2022
@tatevikh tatevikh requested a review from adolkhan May 5, 2022 11:15
AbhinavTuli
AbhinavTuli reviewed May 9, 2022
View reviewed changes
hub/core/chunk_engine.py
for sample in samples:
if isinstance(sample, Sample):
converted.append(convert_sample(sample, mode, self.compression))
elif isinstance(sample, np.ndarray):
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add an else statement raising an exception

@farizrahman4u farizrahman4u merged commit 9bbd640 into main May 9, 2022
@farizrahman4u farizrahman4u deleted the fy_image_htypes branch May 9, 2022 09:03
farizrahman4u added a commit that referenced this pull request May 9, 2022
@farizrahman4u
Revert "[AL-1749] image.rgb and image.gray htypes (#1646)"
a6d7c26 
This reverts commit 9bbd640.
@farizrahman4u farizrahman4u mentioned this pull request May 9, 2022
Merged
farizrahman4u added a commit that referenced this pull request May 9, 2022
@farizrahman4u
Revert "[AL-1749] image.rgb and image.gray htypes (#1646)" (#1662)
ad40eed
@farizrahman4u farizrahman4u restored the fy_image_htypes branch May 9, 2022 09:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@farizrahman4u farizrahman4u farizrahman4u approved these changes

@levongh levongh levongh approved these changes

@AbhinavTuli AbhinavTuli AbhinavTuli approved these changes

@adolkhan adolkhan Awaiting requested review from adolkhan

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@FayazRahman @farizrahman4u @levongh @AbhinavTuli