Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds ability to pop sample from dataset instead of popping from individual tensors #1776

Merged
merged 8 commits into from
Jul 12, 2022

Conversation

AbhinavTuli
Copy link
Contributor

@AbhinavTuli AbhinavTuli commented Jul 11, 2022

🚀 🚀 Pull Request

Checklist:

  • My code follows the style guidelines of this project and the Contributing document
  • I have commented my code, particularly in hard-to-understand areas
  • I have kept the coverage-rate up
  • I have performed a self-review of my own code and resolved any problems
  • I have checked to ensure there aren't any other open Pull Requests for the same change
  • I have described and made corresponding changes to the relevant documentation
  • New and existing unit tests pass locally with my changes

Changes

Adds ds.pop method to Dataset to pop from multiple tensors at once instead of popping from each tensor one by one

@codecov
Copy link

codecov bot commented Jul 11, 2022

Codecov Report

Merging #1776 (475b973) into main (cfb9818) will increase coverage by 0.01%.
The diff coverage is 97.29%.

@@            Coverage Diff             @@
##             main    #1776      +/-   ##
==========================================
+ Coverage   92.73%   92.75%   +0.01%     
==========================================
  Files         227      227              
  Lines       24022    24059      +37     
==========================================
+ Hits        22278    22317      +39     
+ Misses       1744     1742       -2     
Flag Coverage Δ
unittests 92.75% <97.29%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
hub/core/dataset/dataset.py 92.58% <93.33%> (+<0.01%) ⬆️
hub/api/tests/test_pop.py 100.00% <100.00%> (ø)
hub/core/query/filter.py 78.90% <0.00%> (-1.18%) ⬇️
hub/integrations/pytorch/dataset.py 94.27% <0.00%> (+1.52%) ⬆️
hub/integrations/tests/test_pytorch_dataloader.py 97.84% <0.00%> (+2.15%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cfb9818...475b973. Read the comment docs.

@AbhinavTuli AbhinavTuli merged commit 0b60be3 into main Jul 12, 2022
@AbhinavTuli AbhinavTuli deleted the ds/pop branch July 12, 2022 18:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants