Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AL-2290] DeepLake VectorStore updates #2375

Merged
merged 141 commits into from
Jun 6, 2023
Merged

[AL-2290] DeepLake VectorStore updates #2375

merged 141 commits into from
Jun 6, 2023

Conversation

adolkhan
Copy link
Contributor

@adolkhan adolkhan commented May 25, 2023

🚀 🚀 Pull Request

Checklist:

  • My code follows the style guidelines of this project and the Contributing document
  • I have commented my code, particularly in hard-to-understand areas
  • I have kept the coverage-rate up
  • I have performed a self-review of my own code and resolved any problems
  • I have checked to ensure there aren't any other open Pull Requests for the same change
  • I have described and made corresponding changes to the relevant documentation
  • New and existing unit tests pass locally with my changes

Changes

  • Changed Vector Store module to have a more robust API for custom tensors
  • Implemented Vector Store search (including vector search) using python, TQL, or Tensor DB
  • Changed deeplake.like to load the existing dataset first before creating a new one, in order to enable it to overwrite a dataset
  • Changed the Query API and Tensor DB backend client to be more interchangeable between client-side and server-side queries. Also added check to see if runtime parameters are valid.

@adolkhan adolkhan changed the title DeepLake VectorSrore updates DeepLake VectorStore updates May 25, 2023
@adolkhan adolkhan marked this pull request as draft May 25, 2023 09:02
@codecov
Copy link

codecov bot commented May 25, 2023

Codecov Report

Patch coverage: 83.06% and project coverage change: +0.04 🎉

Comparison is base (2ff28ba) 84.67% compared to head (75b197d) 84.71%.

❗ Current head 75b197d differs from pull request most recent head ea7e4e2. Consider uploading reports for the commit ea7e4e2 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2375      +/-   ##
==========================================
+ Coverage   84.67%   84.71%   +0.04%     
==========================================
  Files         323      325       +2     
  Lines       36759    37257     +498     
==========================================
+ Hits        31126    31564     +438     
- Misses       5633     5693      +60     
Flag Coverage Δ
unittests 84.71% <83.06%> (+0.04%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...core/vectorstore/vector_search/dataset/__init__.py 100.00% <ø> (ø)
.../core/vectorstore/vector_search/filter/__init__.py 100.00% <ø> (ø)
deeplake/integrations/huggingface/huggingface.py 88.00% <ø> (ø)
deeplake/core/dataset/dataset.py 91.27% <8.33%> (-0.29%) ⬇️
...ectorstore/vector_search/indra/search_algorithm.py 30.00% <30.00%> (ø)
deeplake/client/client.py 87.57% <50.00%> (+2.40%) ⬆️
...e/vectorstore/vector_search/indra/vector_search.py 57.14% <57.14%> (ø)
...lake/core/vectorstore/test_deeplake_vectorstore.py 65.38% <63.48%> (-8.39%) ⬇️
...ctorstore/vector_search/python/search_algorithm.py 84.61% <84.61%> (ø)
deeplake/core/vectorstore/vector_search/utils.py 92.03% <89.65%> (-7.97%) ⬇️
... and 23 more

... and 22 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@adolkhan adolkhan merged commit 4671200 into main Jun 6, 2023
9 of 13 checks passed
@adolkhan adolkhan deleted the VectorStoreSmallUpdates branch June 6, 2023 13:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

8 participants