Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AL-2293] Support update_creds_key for existing creds #2380

Merged
merged 10 commits into from
Jun 8, 2023

Conversation

FayazRahman
Copy link
Contributor

🚀 🚀 Pull Request

Checklist:

  • My code follows the style guidelines of this project and the Contributing document
  • I have commented my code, particularly in hard-to-understand areas
  • I have kept the coverage-rate up
  • I have performed a self-review of my own code and resolved any problems
  • I have checked to ensure there aren't any other open Pull Requests for the same change
  • I have described and made corresponding changes to the relevant documentation
  • New and existing unit tests pass locally with my changes

Changes

  • Allow replacing creds key with existing creds key
  • Only allowed if management status is the same

@codecov
Copy link

codecov bot commented Jun 2, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.02 🎉

Comparison is base (f6d7f66) 84.70% compared to head (dedbf0d) 84.73%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2380      +/-   ##
==========================================
+ Coverage   84.70%   84.73%   +0.02%     
==========================================
  Files         326      326              
  Lines       37552    37616      +64     
==========================================
+ Hits        31810    31873      +63     
- Misses       5742     5743       +1     
Flag Coverage Δ
unittests 84.73% <100.00%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
deeplake/api/dataset.py 85.04% <ø> (+0.21%) ⬆️
deeplake/api/tests/test_link.py 98.34% <100.00%> (+0.34%) ⬆️
deeplake/core/dataset/dataset.py 91.27% <100.00%> (ø)
deeplake/core/dataset/deeplake_cloud_dataset.py 92.73% <100.00%> (+0.20%) ⬆️
deeplake/core/link_creds.py 92.27% <100.00%> (+0.45%) ⬆️
deeplake/util/link.py 98.11% <100.00%> (ø)

... and 9 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@FayazRahman FayazRahman merged commit 22ba5da into main Jun 8, 2023
@FayazRahman FayazRahman deleted the fy_replace_creds branch June 8, 2023 13:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants