Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[AL-2302] Fix issue with SPINNER_ENABLED const #2384

Merged
merged 3 commits into from
Jun 1, 2023
Merged

[AL-2302] Fix issue with SPINNER_ENABLED const #2384

merged 3 commits into from
Jun 1, 2023

Conversation

farizrahman4u
Copy link
Contributor

🚀 🚀 Pull Request

Checklist:

  • My code follows the style guidelines of this project and the Contributing document
  • I have commented my code, particularly in hard-to-understand areas
  • I have kept the coverage-rate up
  • I have performed a self-review of my own code and resolved any problems
  • I have checked to ensure there aren't any other open Pull Requests for the same change
  • I have described and made corresponding changes to the relevant documentation
  • New and existing unit tests pass locally with my changes

Changes

Setting deeplake.constants.SPINNER_ENABLED = False disables spinner.

@tatevikh tatevikh requested review from levongh and adolkhan May 29, 2023 14:50
@farizrahman4u farizrahman4u merged commit b64fb7f into main Jun 1, 2023
@farizrahman4u farizrahman4u deleted the fr_spinner_enabled_fix branch June 1, 2023 08:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adolkhan adolkhan adolkhan approved these changes

@levongh levongh levongh approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@farizrahman4u @levongh @adolkhan