Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DL-1033] [AL-2312] Error messaging and link verification update #2413

Merged
merged 10 commits into from
Jun 9, 2023

Conversation

FayazRahman
Copy link
Contributor

🚀 🚀 Pull Request

Checklist:

  • My code follows the style guidelines of this project and the Contributing document
  • I have commented my code, particularly in hard-to-understand areas
  • I have kept the coverage-rate up
  • I have performed a self-review of my own code and resolved any problems
  • I have checked to ensure there aren't any other open Pull Requests for the same change
  • I have described and made corresponding changes to the relevant documentation
  • New and existing unit tests pass locally with my changes

Changes

  • Update error produced for ds.connect when user is not member of org
  • Consolidate link verification to verify parameter

@codecov
Copy link

codecov bot commented Jun 8, 2023

Codecov Report

Patch coverage: 83.33% and project coverage change: -0.02 ⚠️

Comparison is base (dedbf0d) 84.73% compared to head (0bc7e7c) 84.71%.

❗ Current head 0bc7e7c differs from pull request most recent head 9e1e060. Consider uploading reports for the commit 9e1e060 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2413      +/-   ##
==========================================
- Coverage   84.73%   84.71%   -0.02%     
==========================================
  Files         326      326              
  Lines       37616    37616              
==========================================
- Hits        31873    31866       -7     
- Misses       5743     5750       +7     
Flag Coverage Δ
unittests 84.71% <83.33%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
deeplake/api/dataset.py 84.53% <40.00%> (-0.51%) ⬇️
deeplake/core/dataset/dataset.py 91.23% <77.77%> (-0.05%) ⬇️
deeplake/api/tests/test_api.py 97.97% <100.00%> (+<0.01%) ⬆️
deeplake/api/tests/test_link.py 98.36% <100.00%> (+0.02%) ⬆️
deeplake/util/exceptions.py 85.11% <100.00%> (+0.02%) ⬆️

... and 15 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@FayazRahman FayazRahman merged commit a9e1836 into main Jun 9, 2023
@FayazRahman FayazRahman deleted the fy_err_msg branch June 9, 2023 14:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants