Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VectorStore ids backwards compatibility #2446

Merged
merged 7 commits into from
Jun 22, 2023

Conversation

adolkhan
Copy link
Contributor

🚀 🚀 Pull Request

Checklist:

  • My code follows the style guidelines of this project and the Contributing document
  • I have commented my code, particularly in hard-to-understand areas
  • I have kept the coverage-rate up
  • I have performed a self-review of my own code and resolved any problems
  • I have checked to ensure there aren't any other open Pull Requests for the same change
  • I have described and made corresponding changes to the relevant documentation
  • New and existing unit tests pass locally with my changes

Changes

Added backwards compatibility for add method

@codecov
Copy link

codecov bot commented Jun 22, 2023

Codecov Report

Patch coverage: 98.46% and project coverage change: +0.01 🎉

Comparison is base (c88925d) 84.73% compared to head (6bf4be0) 84.74%.

❗ Current head 6bf4be0 differs from pull request most recent head 20c10be. Consider uploading reports for the commit 20c10be to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2446      +/-   ##
==========================================
+ Coverage   84.73%   84.74%   +0.01%     
==========================================
  Files         326      326              
  Lines       37889    37933      +44     
==========================================
+ Hits        32104    32148      +44     
  Misses       5785     5785              
Flag Coverage Δ
unittests 84.74% <98.46%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
.../core/vectorstore/vector_search/dataset/dataset.py 97.68% <97.14%> (+0.26%) ⬆️
...lake/core/vectorstore/test_deeplake_vectorstore.py 71.59% <100.00%> (+1.41%) ⬆️
.../vectorstore/vector_search/dataset/test_dataset.py 93.79% <100.00%> (+0.52%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

adolkhan and others added 5 commits June 22, 2023 22:02
Co-authored-by: Fayaz Rahman <fayazrahman4u@gmail.com>
Co-authored-by: Fayaz Rahman <fayazrahman4u@gmail.com>
Co-authored-by: Fayaz Rahman <fayazrahman4u@gmail.com>
Co-authored-by: Fayaz Rahman <fayazrahman4u@gmail.com>
Co-authored-by: Fayaz Rahman <fayazrahman4u@gmail.com>
@adolkhan adolkhan merged commit abd1f36 into main Jun 22, 2023
@adolkhan adolkhan deleted the vectorstore_ids_bakwards_compatibility branch June 22, 2023 16:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants