Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add sonarcloud scan badge #2474

Merged
merged 6 commits into from
Jul 17, 2023
Merged

add sonarcloud scan badge #2474

merged 6 commits into from
Jul 17, 2023

Conversation

artgish
Copy link
Collaborator

@artgish artgish commented Jul 11, 2023

🚀 🚀 Pull Request

Checklist:

  • My code follows the style guidelines of this project and the Contributing document
  • I have commented my code, particularly in hard-to-understand areas
  • I have kept the coverage-rate up
  • I have performed a self-review of my own code and resolved any problems
  • I have checked to ensure there aren't any other open Pull Requests for the same change
  • I have described and made corresponding changes to the relevant documentation
  • New and existing unit tests pass locally with my changes

Changes

  • Add SonarCloud scanner badges
  • Fix 404 links

@mikayelh
Copy link
Collaborator

what's @istranic's thoughts on these badges? i'm not a fan - can we reduce the amount and keep the most relevant ones?

@mikayelh
Copy link
Collaborator

thx for fiing 404s though!!!

@davidbuniat
Copy link
Member

please reduce 1 or 2 badges that are most important.

@artgish
Copy link
Collaborator Author

artgish commented Jul 11, 2023

thx for fiing 404s though!!!

@mikayelh , can you verify that new links are corect ones?

@codecov
Copy link

codecov bot commented Jul 15, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.09 ⚠️

Comparison is base (42d4b5d) 84.91% compared to head (2e328b2) 84.83%.

❗ Current head 2e328b2 differs from pull request most recent head d4b0fce. Consider uploading reports for the commit d4b0fce to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2474      +/-   ##
==========================================
- Coverage   84.91%   84.83%   -0.09%     
==========================================
  Files         328      327       -1     
  Lines       38513    38414      -99     
==========================================
- Hits        32703    32588     -115     
- Misses       5810     5826      +16     
Flag Coverage Δ
unittests 84.83% <ø> (-0.09%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 21 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@artgish artgish changed the title add sonarcloud scan badges add sonarcloud scan badge Jul 16, 2023
@artgish artgish requested review from nvoxland and removed request for istranic July 16, 2023 15:26
@nvoxland nvoxland changed the base branch from main to AbhinavTuli-patch-1 July 17, 2023 14:39
@nvoxland nvoxland changed the base branch from AbhinavTuli-patch-1 to main July 17, 2023 14:39
@artgish artgish merged commit 5301335 into main Jul 17, 2023
7 of 9 checks passed
@artgish artgish deleted the devops/pr-1689051088 branch July 17, 2023 14:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants