Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improvements to to_tensorflow and BBox, Classlabel schemas #658

Merged
merged 7 commits into from
Mar 8, 2021

Conversation

AbhinavTuli
Copy link
Contributor

@AbhinavTuli AbhinavTuli commented Mar 8, 2021

to_tensorflow now works better with Text data.
ClassLabel and BBox schemas now support multiple ClassLabels and BBoxes. Better shape checks also added for both of these. Docstrings also improved. This should replace most usecases for Sequences

@github-actions
Copy link

github-actions bot commented Mar 8, 2021

Locust summary

Git references

Initial: 389d2da
Terminal: 97214c8

hub/api/integrations.py
Changes:
hub/api/datasetview.py
Changes:
hub/compute/transform.py
Changes:
hub/schema/bbox.py
Changes:
  • Name: BBox
    Type: class
    Changed lines: 28
    Total lines: 57
    Changes:
hub/schema/class_label.py
Changes:
hub/api/dataset.py
Changes:
hub/api/tensorview.py
Changes:
  • Name: TensorView
    Type: class
    Changed lines: 11
    Total lines: 334
    Changes:
hub/compute/ray.py
Changes:
benchmarks/benchmark_sequential_write.py
Changes:
  • Name: time_batches
    Type: function
    Changed lines: 1
    Total lines: 25
    hub/api/tests/test_dataset.py
    Changes:
    hub/schema/deserialize.py
    Changes:
    • Name: deserialize
      Type: function
      Changed lines: 6
      Total lines: 123
      hub/schema/sequence.py
      Changes:
      • Name: Sequence
        Type: class
        Changed lines: 2
        Total lines: 50
        hub/schema/tests/test_features.py
        Changes:

        @codecov
        Copy link

        codecov bot commented Mar 8, 2021

        Codecov Report

        Merging #658 (6d1e6c9) into master (389d2da) will decrease coverage by 0.08%.
        The diff coverage is 86.11%.

        Impacted file tree graph

        @@            Coverage Diff             @@
        ##           master     #658      +/-   ##
        ==========================================
        - Coverage   89.03%   88.95%   -0.09%     
        ==========================================
          Files          57       57              
          Lines        4049     4073      +24     
        ==========================================
        + Hits         3605     3623      +18     
        - Misses        444      450       +6     
        Impacted Files Coverage Δ
        hub/api/dataset.py 88.91% <ø> (-0.44%) ⬇️
        hub/schema/deserialize.py 100.00% <ø> (ø)
        hub/schema/sequence.py 100.00% <ø> (ø)
        hub/api/integrations.py 87.63% <54.54%> (-0.60%) ⬇️
        hub/api/datasetview.py 92.00% <100.00%> (-0.57%) ⬇️
        hub/api/tensorview.py 90.45% <100.00%> (+0.29%) ⬆️
        hub/compute/ray.py 96.35% <100.00%> (ø)
        hub/compute/transform.py 93.42% <100.00%> (ø)
        hub/schema/bbox.py 100.00% <100.00%> (ø)
        hub/schema/class_label.py 100.00% <100.00%> (ø)
        ... and 1 more

        Continue to review full report at Codecov.

        Legend - Click here to learn more
        Δ = absolute <relative> (impact), ø = not affected, ? = missing data
        Powered by Codecov. Last update 389d2da...6d1e6c9. Read the comment docs.

        @AbhinavTuli AbhinavTuli merged commit 853456a into master Mar 8, 2021
        @AbhinavTuli AbhinavTuli deleted the fixes/hub_improvements branch March 22, 2021 04:34
        Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
        Labels
        None yet
        Projects
        None yet
        Development

        Successfully merging this pull request may close these issues.

        2 participants