-
Notifications
You must be signed in to change notification settings - Fork 625
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update tensors from generic types to hub schema representations #705
Conversation
Locust summaryGit referencesInitial: 46e6cecTerminal: 0621b9e hub/api/integrations.pyChanges:
hub/api/dataset.pyChanges:
hub/store/dynamic_tensor.pyChanges:
hub/api/datasetview.pyChanges:
hub/api/tensorview.pyChanges:
hub/compute/transform.pyChanges:
hub/store/metastore.pyChanges:
hub/api/tests/test_converters.pyChanges:
hub/api/tests/test_dataset.pyChanges:
hub/cli/auth.pyChanges:
hub/store/tests/test_dynamic_tensor.pyChanges:
hub/utils.pyChanges:
|
Codecov Report
@@ Coverage Diff @@
## master #705 +/- ##
=======================================
Coverage 88.95% 88.95%
=======================================
Files 58 58
Lines 4266 4266
=======================================
Hits 3795 3795
Misses 471 471 Continue to review full report at Codecov.
|
This looks great @haiyangdeperci!
|
@mynameisvinn What do you think of clearing out just the installation output? That way those who browse the notebooks will be able to see what we do here. |
Yep good idea, clearing pip activity will make things more clear. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Everything looks good.
Just one recommendation, can we change the element in the example for shoeing bounding boxes. The given bike doesn't have a very good bounding box.
Can we use some good example instead. Anything else will do. Rest all looks good to me.
I swapped the example, I think it looks good. Ready to merge after you re-review it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
This PR reflects the changes to the Objectron datasets' schema, i.e. the substitution of generic tensor types with hub schema representations.