Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update tensors from generic types to hub schema representations #705

Merged
merged 5 commits into from
Mar 24, 2021

Conversation

haiyangdeperci
Copy link
Contributor

This PR reflects the changes to the Objectron datasets' schema, i.e. the substitution of generic tensor types with hub schema representations.

@github-actions
Copy link

Locust summary

Git references

Initial: 46e6cec
Terminal: 0621b9e

hub/api/integrations.py
Changes:
hub/api/dataset.py
Changes:
hub/store/dynamic_tensor.py
Changes:
hub/api/datasetview.py
Changes:
hub/api/tensorview.py
Changes:
  • Name: TensorView
    Type: class
    Changed lines: 7
    Total lines: 335
    Changes:
hub/compute/transform.py
Changes:
  • Name: Transform
    Type: class
    Changed lines: 10
    Total lines: 399
    Changes:
hub/store/metastore.py
Changes:
hub/api/tests/test_converters.py
Changes:
hub/api/tests/test_dataset.py
Changes:
hub/cli/auth.py
Changes:
  • Name: reporting
    Type: function
    Changed lines: 1
    Total lines: 11
    hub/store/tests/test_dynamic_tensor.py
    Changes:
    hub/utils.py
    Changes:
    • Name: batchify
      Type: function
      Changed lines: 2
      Total lines: 9

      @codecov
      Copy link

      codecov bot commented Mar 22, 2021

      Codecov Report

      Merging #705 (aadef32) into master (68d851e) will not change coverage.
      The diff coverage is n/a.

      Impacted file tree graph

      @@           Coverage Diff           @@
      ##           master     #705   +/-   ##
      =======================================
        Coverage   88.95%   88.95%           
      =======================================
        Files          58       58           
        Lines        4266     4266           
      =======================================
        Hits         3795     3795           
        Misses        471      471           

      Continue to review full report at Codecov.

      Legend - Click here to learn more
      Δ = absolute <relative> (impact), ø = not affected, ? = missing data
      Powered by Codecov. Last update 68d851e...aadef32. Read the comment docs.

      @mynameisvinn
      Copy link
      Contributor

      This looks great @haiyangdeperci!

      1. For get_bbox, can we pass element as an argument and/or keep it in the local scope?
      2. Mind clearing cell outputs when you're done? (You can find it in the cell tab.)

      @haiyangdeperci
      Copy link
      Contributor Author

      @mynameisvinn What do you think of clearing out just the installation output? That way those who browse the notebooks will be able to see what we do here.
      I've changed the function to accept element as the argument. Let me know if that's sufficient.

      @mynameisvinn
      Copy link
      Contributor

      Yep good idea, clearing pip activity will make things more clear.

      @mynameisvinn mynameisvinn added dataset enhancement New feature or request labels Mar 23, 2021
      Copy link
      Contributor

      @imshashank imshashank left a comment

      Choose a reason for hiding this comment

      The reason will be displayed to describe this comment to others. Learn more.

      Everything looks good.
      Just one recommendation, can we change the element in the example for shoeing bounding boxes. The given bike doesn't have a very good bounding box.

      Can we use some good example instead. Anything else will do. Rest all looks good to me.

      @haiyangdeperci
      Copy link
      Contributor Author

      I swapped the example, I think it looks good. Ready to merge after you re-review it.

      Copy link
      Contributor

      @imshashank imshashank left a comment

      Choose a reason for hiding this comment

      The reason will be displayed to describe this comment to others. Learn more.

      LGTM

      @haiyangdeperci haiyangdeperci merged commit 96a3e49 into master Mar 24, 2021
      Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
      Labels
      dataset enhancement New feature or request
      Projects
      None yet
      Development

      Successfully merging this pull request may close these issues.

      4 participants