Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SER-728 Create Verve Card Type. #4875

Merged
merged 2 commits into from
Sep 6, 2023
Merged

Conversation

jherreraa
Copy link
Collaborator

@jherreraa jherreraa commented Aug 25, 2023

This change add new credit card brand Verve and tests related to it.

Copy link
Contributor

@sinourain sinourain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@Heavyblade Heavyblade left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the basic implementation looks 👍 @jherreraa, lef a style comment and I have one question:

❓ => Shouldn't this PR also include the addition of the new credit card type to Rapyd?

test/unit/credit_card_methods_test.rb Show resolved Hide resolved
@jherreraa jherreraa force-pushed the SER-728_VERVE_Create_Card_Type branch from 5609c49 to c45eaa3 Compare August 29, 2023 12:45
Copy link
Contributor

@naashton naashton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good! Can we also include a CHANGELOG entry?

@naashton naashton force-pushed the SER-728_VERVE_Create_Card_Type branch from c45eaa3 to 7bda2e0 Compare September 6, 2023 14:19
@naashton naashton merged commit 2eeb3ab into master Sep 6, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants