-
Notifications
You must be signed in to change notification settings - Fork 428
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Slice FNBO icon #880
Slice FNBO icon #880
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your submission. Please use our template in the contribution guidelines. The border radius and border colour are incorrect, the name and filename cannot have special characters. I would check the actual vectors in the logo too, it looks like this may have been autotraced in Illustrator and you should submit the original vectors.
@Jacquesattaque We have updated the icon per the guidelines and fixed the issues mentioned in the previous icon. Please review it again. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The logo looks better, but the corner radius still doesn't match. Please use our template. The name and SVG cannot have special characters, so please remove the dash.
@Jacquesattaque We have removed "dash" from the name and SVG as per your feedback. Border radius have also been matched. Please review it again. |
Why are you adding this icons?
I'm adding/updating this icon(s) because fnbo will use shopify as a payment gateway
Help us identify yourself
Link to the brand guidelines:
Checklist to add new icons
db/payment_icons.yml
If this pull request is not adding new icons, you can remove this checklist.
Attach a screenshot of the icon along side the example Visa icon
Tips how to create a screenshot
We have found free online SVG editor https://www.freecodeformat.com/svg-editor.php very useful to create one. Here is a sample code for you to verify that you icon appears properly along side the placeholder.
If the icons are intended for use by Shopify, please provide the following info:
Who are you working with at Shopify? (avoid adding personal details, provide github handle(preferred) or first name and last name)
What's the expected date of this change to deploy on Shopify?