Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are you adding this icons?
I'm adding these icons because Sika is a Shopify Payments Partner for HSA/FSA spending, and we are going through a brand redesign where the look and feel of our flow is changing, including the icons.
Help us identify yourself
Link to the brand guidelines:
Here is a link to the Sika Brand Kit for Shopify Merchants
Checklist to add new icons
db/payment_icons.yml
If this pull request is not adding new icons, you can remove this checklist.
Attach a screenshot of the icon along side the example Visa icon
If the icons are intended for use by Shopify, please provide the following info:
Who are you working with at Shopify? (avoid adding personal details, provide github handle(preferred) or first name and last name)
Adeniyi Adeyemi
What's the expected date of this change to deploy on Shopify?
We would like to resubmit our application with our entire branded redesign, it will have to be approved and then go live.
Because we already use two icons, and I am replacing them, those two icons would go live when this would be approved.