Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sika updated icons #905

Merged
merged 2 commits into from
Sep 6, 2023
Merged

Conversation

sarahsp-sika
Copy link
Contributor

@sarahsp-sika sarahsp-sika commented Aug 10, 2023

Why are you adding this icons?

I'm adding these icons because Sika is a Shopify Payments Partner for HSA/FSA spending, and we are going through a brand redesign where the look and feel of our flow is changing, including the icons.

Help us identify yourself

  • I'm working/collaborating with the brand directly and they have provided the icons.
  • I'm associated with the brand and I've read all the brand icon’s guidelines.
  • I'm an individual and I've read all the brand icon’s guidelines.

Link to the brand guidelines:
Here is a link to the Sika Brand Kit for Shopify Merchants

Checklist to add new icons

  • All icons have a corresponding entry in db/payment_icons.yml
  • I have followed the icon guidelines detailed in the CONTRIBUTING.md file
  • I have optimized the icon with SVGO
  • I am confident that all icons are clear and easy to read/understand
  • I have provided a link to the brand icon’s brand guidelines whenever possible.
  • I have attached a screenshot comparison with the example icon provided in guidelines
  • I recognize that if my icon is not approved by the Shopify Partners team it may not receive review nor merger.

If this pull request is not adding new icons, you can remove this checklist.

Attach a screenshot of the icon along side the example Visa icon

sikascreenshot sikahsascreenshot sikafsascreenshot

If the icons are intended for use by Shopify, please provide the following info:

Who are you working with at Shopify? (avoid adding personal details, provide github handle(preferred) or first name and last name)
Adeniyi Adeyemi

What's the expected date of this change to deploy on Shopify?
We would like to resubmit our application with our entire branded redesign, it will have to be approved and then go live.
Because we already use two icons, and I am replacing them, those two icons would go live when this would be approved.

@sarahsp-sika
Copy link
Contributor Author

I am still in the process of adding our brand guideline information, and have listed this PR as a draft, I hope that is okay! I will mark it ready for review when it is good to go.

@sarahsp-sika sarahsp-sika marked this pull request as ready for review August 10, 2023 22:15
@sarahsp-sika
Copy link
Contributor Author

This PR is good to go now!

@sarahsp-sika
Copy link
Contributor Author

Hello @Jacquesattaque, I was just wondering when the next deploy will be/ when to expect these icons available. Thank you!!

@Jacquesattaque
Copy link
Contributor

@sarahsp-sika We aim to do a release on the first Wednesday of every month. The next release is tentatively scheduled for September 6.

@adeniyiao adeniyiao merged commit b9ab165 into activemerchant:master Sep 6, 2023
11 checks passed
@shopify-shipit-activemerchant shopify-shipit-activemerchant bot temporarily deployed to rubygems September 6, 2023 15:18 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants