Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mypy workflow setup #430

Merged
merged 1 commit into from
Oct 11, 2023
Merged

mypy workflow setup #430

merged 1 commit into from
Oct 11, 2023

Conversation

to-sta
Copy link
Collaborator

@to-sta to-sta commented Oct 9, 2023

Contributor checklist


Description

In this PR i have added mypy (Static Type Checking for python) to the backend workflow. This is the last missing piece for the issue #329.

I tested the cli command locally and then run the workflow via act.

Comments:
While looking into the workflows, i was thinking that we should rename the files now. pr_backend_formatting_check does linting and static type checking. I think pr_ci_backend would make sense. I will open an issue for that and a few more minor things regarding workflows.

Related issue

@netlify
Copy link

netlify bot commented Oct 9, 2023

Deploy Preview for activist-org canceled.

Name Link
🔨 Latest commit 7fd4528
🔍 Latest deploy log https://app.netlify.com/sites/activist-org/deploys/6523b54fab50380008eea46b

@github-actions
Copy link
Contributor

github-actions bot commented Oct 9, 2023

Thank you for the pull request!

The activist team will do our best to address your contribution as soon as we can. The following is a checklist for maintainers to make sure this process goes as well as possible. Feel free to address the points below yourself in further commits if you realize that actions are needed :)

If you're not already a member of our public Matrix community, please consider joining! We'd suggest using Element as your Matrix client, and definitely join the General and Development rooms once you're in. It'd be great to have you!

Maintainer checklist

  • The commit messages for the remote branch should be checked to make sure the contributor's email is set up correctly so that they receive credit for their contribution

    • The contributor's name and icon in remote commits should be the same as what appears in the PR
    • If there's a mismatch, the contributor needs to make sure that the email they use for GitHub matches what they have for git config user.email in their local activist repo
  • The TypeScript and formatting workflows within the PR checks do not indicate new errors in the files changed

  • The CHANGELOG has been updated with a description of the changes for the upcoming release (if necessary)

@andrewtavis andrewtavis self-requested a review October 9, 2023 09:39
@andrewtavis andrewtavis added the hacktoberfest-accepted Accepted as a part of Hacktoberfest label Oct 9, 2023
Copy link
Member

@andrewtavis andrewtavis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the edits here @to-sta as well as the new issues to keep the setup improvements rolling! 🚚😊

@andrewtavis andrewtavis merged commit 6192390 into activist-org:main Oct 11, 2023
8 checks passed
@to-sta to-sta deleted the mypyWorkflow branch April 21, 2024 10:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hacktoberfest-accepted Accepted as a part of Hacktoberfest
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants