Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updated signup, login and added pwreset API #880

Merged
merged 7 commits into from
Jun 9, 2024

Conversation

to-sta
Copy link
Collaborator

@to-sta to-sta commented May 19, 2024

Contributor checklist


Description

I made some changes to the account related API:

  • added password reset endpoint
  • changed login to accept either username or email
  • added email settings to .env.dev and django
  • changed signup to work with either username or username and email
    • if email is used than a email address confirmation mail will be send

The email backend settings is only for development.

I have done initial manual testing, but the automated tests for login and signup need to be adjusted. Also password reset tests need to be added.

Related issue

Copy link
Contributor

github-actions bot commented May 19, 2024

Thank you for the pull request!

The activist team will do our best to address your contribution as soon as we can. The following is a checklist for maintainers to make sure this process goes as well as possible. Feel free to address the points below yourself in further commits if you realize that actions are needed :)

If you're not already a member of our public Matrix community, please consider joining! We'd suggest using Element as your Matrix client, and definitely join the General and Development rooms once you're in. Also consider joining our bi-weekly Saturday dev syncs. It'd be great to have you!

Maintainer checklist

  • The commit messages for the remote branch should be checked to make sure the contributor's email is set up correctly so that they receive credit for their contribution

    • The contributor's name and icon in remote commits should be the same as what appears in the PR
    • If there's a mismatch, the contributor needs to make sure that the email they use for GitHub matches what they have for git config user.email in their local activist repo
  • The TypeScript and formatting workflows within the PR checks do not indicate new errors in the files changed

  • The Playwright end to end and Zap penetration tests have been ran and are passing (if necessary)

  • The CHANGELOG has been updated with a description of the changes for the upcoming release and the corresponding issue (if necessary)

Copy link

netlify bot commented May 19, 2024

Deploy Preview for activist-org canceled.

Name Link
🔨 Latest commit b2b2d8d
🔍 Latest deploy log https://app.netlify.com/sites/activist-org/deploys/6665d563d62bd8000863b0dc

@andrewtavis andrewtavis self-requested a review May 19, 2024 23:46
<p>Hi {{username}},</p>
<p>We have received a request to reset your password. To proceed with the password reset, please click on the link below:</p>
<p><a href={{pwreset_link}}>Reset Password</a></p>
<p>If you did not request a password reset, please ignore this email.</p>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We could do "If you did not request a password reset, then it's safe to ignore this email."

Copy link
Member

@andrewtavis andrewtavis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for all the changes here, @to-sta! Made #898 as discussed :)

@andrewtavis andrewtavis merged commit 600d6e7 into activist-org:main Jun 9, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants