Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add ability to name a handler function as 'config' #1290

Merged
merged 3 commits into from
Jan 25, 2020
Merged

Add ability to name a handler function as 'config' #1290

merged 3 commits into from
Jan 25, 2020

Conversation

gtors
Copy link
Contributor

@gtors gtors commented Jan 20, 2020

Fixes #1277

@codecov-io
Copy link

codecov-io commented Jan 20, 2020 •
edited
Loading

Codecov Report

❗ No coverage uploaded for pull request base (master@3a5b62b). Click here to learn what that means.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #1290   +/-   ##
=========================================
  Coverage          ?   80.46%           
=========================================
  Files             ?      159           
  Lines             ?    18544           
  Branches          ?        0           
=========================================
  Hits              ?    14921           
  Misses            ?     3623           
  Partials          ?        0
Impacted Files Coverage Δ
actix-web-codegen/src/route.rs 0% <0%> (ø)
actix-web-codegen/tests/test_macro.rs 93.4% <0%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3a5b62b...d1d441a. Read the comment docs.

@robjtede robjtede requested a review from a team January 20, 2020 22:04
cetra3
cetra3 approved these changes Jan 20, 2020
View reviewed changes
Copy link
Contributor

@cetra3 cetra3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@oronsh
Copy link

oronsh commented Jan 22, 2020

Can you guys share please why this is happened? I'm very interested to know 👍

@JohnTitor
Copy link
Member

(off-topic: @robjtede Please do not drop waiting-on-review label even if one reviewer approves it. Other reviewers may have different views.)

@gtors
Copy link
Contributor Author

gtors commented Jan 22, 2020

Can you guys share please why this is happened? I'm very interested to know +1

@oronsh name collision with variable generated via procedural macros

JohnTitor
JohnTitor approved these changes Jan 25, 2020
View reviewed changes
Copy link
Member

@JohnTitor JohnTitor left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you also update changes.md with the PR number and link?

@gtors
Copy link
Contributor Author

gtors commented Jan 25, 2020

Could you also update changes.md with the PR number and link?

Sure

@JohnTitor
Copy link
Member

Ah, you should update changes.md in actix-web-codegen, not in the root.

@gtors
Copy link
Contributor Author

gtors commented Jan 25, 2020 •
edited
Loading

Ah, you should update changes.md in actix-web-codegen, not in the root.

My bad

@gtors
Copy link
Contributor Author

gtors commented Jan 25, 2020

Done

@JohnTitor JohnTitor merged commit 71d1164 into actix:master Jan 25, 2020
@JohnTitor
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JohnTitor JohnTitor JohnTitor approved these changes

@cetra3 cetra3 cetra3 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Cannot name function as config when using #[get] macro
6 participants
@gtors @codecov-io @oronsh @JohnTitor @cetra3 @robjtede