implement App::data as App::app_data(Data::new(T)))
#1906
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robjtede
changed the title
App::data as App::app_data(Data::new(T)))
robjtede
added
A-web
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Type
Refactor / Fix
PR Checklist
Overview
Removes some code in
AppServicethat has been redundant since the introduction of layered data containers.Implements
App::datain the logical way.Fixes bug where multiple calls to
App::datawould not retain the latest call's data, unlikeApp::app_data. A test was added for it.Adds some docs to
ServiceConfig.