fix master branch build. change web::block output type. #1957
Conversation
fakeshadow
added
A-files
| ChunkedReadFileState::Future(ref mut fut) => { | ||
| let (file, bytes) = | ||
| ready!(Pin::new(fut).poll(cx)).map_err(|_| BlockingError)??; | ||
| this.state = ChunkedReadFileState::File(Some(file)); |
There was a problem hiding this comment.
I wonder would it decrease number of polls spawning next chunk future right here?
There was a problem hiding this comment.
From the structure of this future. The caller is responsible to actively poll an extra round when he get Some(Bytes) from the stream to go into the file branch again. Otherwise this stream would be stuck.
And I believe downstream API would be doing this. This is an internal stream chain that I think it's better to leave this way. Using Context::waker::wake_by_ref here certainlly is a good way to self wakeup but I'm afraid it would have a liitle bit more overhead than the downstream caller handling it(or result in more polling than needed as it does not aware this change)
There was a problem hiding this comment.
I see, makes sense in that case
PR Type
Refactor
PR Checklist
Overview
Change
web::blockto output any type the closure gives in Ok variant.(Send + 'static bound).Simplify
BlockingErrortype to only triggered by blocking threadpool dead.Reduce size of
actix_files::ChunkReadFileby 8 bytes.Temoprary fix git build by pin dep version.