-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adjust JSON limit to 2MB and report on sizes #2162
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fakeshadow
added
A-web
project: actix-web
B-semver-major
breaking change requiring a major version bump
labels
Apr 15, 2021
I think it's fine to relax the limit in general. We need a changelog for limit and error changes |
Done! |
robjtede
reviewed
Apr 15, 2021
Thanks for the PR, is this just waiting for the conflicts to be resolved ? |
@thalesfragoso sorry didn't notice that it was blocked on conflicts. I've merged master into this PR |
robjtede
approved these changes
Jun 16, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Type
Other
PR Checklist
Overview
This adjusts the default limit of JSON payloads to 2mb from 32kb and adjusts the error to include what the limits are when they're hit. As this changes the error enum & has possibly knock on effects to memory usage by allowing more through this is probably considered a breaking change.
To justify the increase, I have looked at other defaults in other software for what their limits are:
(Honestly, I'd much prefer having no limit at all by default as these things seem to have a way of coming back to bite at unrealistic times, like 2am on a saturday morning!)