Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

copy original route macro input with compile errors #2410

Merged
merged 2 commits into from
Oct 14, 2021
Merged

Conversation

robjtede
Copy link
Member

@robjtede robjtede commented Oct 14, 2021

PR Type

Fix

PR Checklist

  • Tests for the changes have been added / updated.
  • Documentation comments have been added / updated.
  • A changelog entry has been made for the appropriate packages.
  • Format code with the latest stable rustfmt.
  • (Team) Label with affected crates and semver status.

Overview

Same purpose as actix/actix-net#391.

Compile error output has changed now that the original code is actually output and, therefore, the emitted handlers do not impl HttpServiceFactory.

Closes #2394

@robjtede robjtede added A-codegen project: actix-web-codegen B-semver-minor labels Oct 14, 2021
@robjtede robjtede merged commit 6b3ea4f into master Oct 14, 2021
@robjtede robjtede deleted the ide-route-macros branch October 14, 2021 17:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-codegen project: actix-web-codegen B-semver-patch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Actix-web's attribute macros are not IDE friendly
1 participant