-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
wrap LanguageTags
type in new AnyOrSome
type to support wildcards
#2480
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robjtede
added
A-web
project: actix-web
B-semver-major
breaking change requiring a major version bump
labels
Dec 1, 2021
cc @Dexterp37 |
robjtede
changed the title
wrap LanguageTags type in new AnyOrSome type to support wildcards
wrap Dec 1, 2021
LanguageTags
type in new AnyOrSome
type to support wildcards
I assume you are trying to avoid a compound-word name. Here are some ideas:
enum Preference<T> {
Any,
Specific(T)
}
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Type
Fix
PR Checklist
Overview
Introduce new
AnyOrSome
(bikeshedding welcome) wrapper type to support wildcard items in header types where the backing type has no concept of wildcard/any types.Used initially in
AcceptLanguage
but for consistency it might make sense to re-workAccept
(which does know about wildcards).fixes #2434