Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add macro feature #2619

Merged
merged 3 commits into from
Feb 1, 2022
Merged

add macro feature #2619

merged 3 commits into from
Feb 1, 2022

Conversation

robjtede
Copy link
Member

@robjtede robjtede commented Feb 1, 2022 •
edited
Loading

PR Type

Refactor

PR Checklist

  • Tests for the changes have been added / updated.
  • Documentation comments have been added / updated.
  • A changelog entry has been made for the appropriate packages.
  • Format code with the latest stable rustfmt.
  • (Team) Label with affected crates and semver status.

Overview

Add on-by-default feature flag for macro routing and runtime.

Also remove some cruft from rt module.

@robjtede robjtede added A-web project: actix-web B-semver-major breaking change requiring a major version bump labels Feb 1, 2022
@robjtede robjtede added this to the actix-web v4 milestone Feb 1, 2022
@robjtede robjtede requested a review from a team February 1, 2022 02:02
ibraheemdev
ibraheemdev reviewed Feb 1, 2022
View reviewed changes
Copy link
Member

@ibraheemdev ibraheemdev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

actix-web/src/app.rs Outdated Show resolved Hide resolved
@robjtede @ibraheemdev
Update actix-web/src/app.rs
4cc20bc 
Co-authored-by: Ibraheem Ahmed <ibrah1440@gmail.com>
@robjtede robjtede merged commit 40a4b1c into master Feb 1, 2022
@robjtede robjtede deleted the macro-feature branch February 1, 2022 02:35
@ibraheemdev ibraheemdev mentioned this pull request Feb 1, 2022
Closed
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ibraheemdev ibraheemdev ibraheemdev left review comments

Assignees
No one assigned
Labels
A-web project: actix-web B-semver-major breaking change requiring a major version bump
Projects
None yet
Milestone
actix-web v4
Development

Successfully merging this pull request may close these issues.
2 participants
@robjtede @ibraheemdev