added support for creating custom methods with route macro

[edgerunnergit]

PR Type

An improvement to existing feature.

PR Checklist

• Tests for the changes have been added / updated.
• Documentation comments have been added / updated.
• A changelog entry has been made for the appropriate packages.
• Format code with the latest stable rustfmt.
• (Team) Label with affected crates and semver status.

Overview

Current Behavior:

#[route("/my/path", method = "CREATE")]
async fn create() -> HttpResponse {
  // ...

If we wish to use custom methods using the route macro, it causes panic due to Unexpected HTTP method.

New Behavior:

#[route("/heya", method = "NOLAN", method = "BET", method = "GET")]
async fn manual_heya() -> impl Responder {
    HttpResponse::Ok().body("Hey there ya!\n")
}

This would be a valid format - and we can curl with either of the three methods (Provided it's an uppercase ASCII).

To achieve this, I added a Custom Method in MethodTypes which supported any uppercase Method that isn't one of the standard ones.

Extra:

I haven't yet added the tests and documentation for it - but I plan to do it slowly as the issue progresses.

Closes #2893

[robjtede]

I'd like to avoid needing a new type in actix_web. We already have the Method guard which should be used for this feature.

[edgerunnergit]

I'd like to avoid needing a new type in actix_web. We already have the Method guard which should be used for this feature.

Thanks. I tried to make it work. Sorry for all the bad commits. I'm not familiar with git enough. Need to brush up my skills.

[robjtede]

would be good to add at least one test for failure cases like lowercase method = "hello"

[edgerunnergit]

would be good to add at least one test for failure cases like lowercase method = "hello"

done. added a trybuild method for that with stderr similar to other tests.

[edgerunnergit]

@robjtede sorry for the repeated small fixes. I'm having trouble testing out the trybuild tests or the github action tests in local environment hence not able to fix them in one go.

[robjtede]

It should be enough to install the 1.59.0 toolchain and run TRYBUILD=override cargo +1.59.0 test locally.

[edgerunnergit]

TRYBUILD=override cargo +1.59.0 test

I tried to make it work this way earlier but always greeted with the following error:

❯ TRYBUILD=override cargo +1.59.0 test
    Updating crates.io index
error: failed to select a version for the requirement `time = "^0.3"`
candidate versions found which didn't match: 0.3.15, 0.3.14, 0.3.13, ...
location searched: crates.io index
required by package `actix-web v4.3.0 (/home/user/actix-web/actix-web)`

[robjtede]

Ahh of course, need to follow what the CI does here and here with some tweaks for time probably.

[robjtede]

great, thanks 👍