actix-files: Properly handle newlines in file names

[svenstaro]

PR Type

Bug Fix

PR Checklist

• Tests for the changes have been added / updated.
• Documentation comments have been added / updated.
• A changelog entry has been made for the appropriate packages.
• Format code with the latest stable rustfmt.
• (Team) Label with affected crates and semver status.

Overview

This used to result in the issue I reported here: #3234
This shouldn't break anything as so far it was just a 500 error. Afterwards, it should be fixed. On Windows where newlines are illegal (I think), this shouldn't even get there.

Closes #3234.

[robjtede]

nice one, thanks 👍🏻

[robjtede]

released in v0.6.4

[Dialga]

Thanks @svenstaro, that fixes my specific issue in the latest miniserve but I've just tried testing other whitespace characters such as:

echo hi > $'\r\n'rnl.txt
echo hi > $'\v\n'vnl.txt
echo hi > $'\f\t'fnl.txt

These still result in a server error:

500 Internal Server Error
failed to parse header value

There may be more cases, I haven't tried the whole ascii table.
Let's hope no one uses those file names!

[svenstaro]

I was unaware that these are also legal white spaces for common filesystems! Maybe @Dialga you could go ahead and amend my fix to contain other legal white spaces as well? Should be super straight forward to take my work and build on that by adding a few replace().

[Dialga]

Hi I'm a noob with rust, but I'll take a shot!

[svenstaro]

Hi I'm a noob with rust, but I'll take a shot!

Just check what I did and then do more of that. Don't forget the test case!