Namespacing and isolating engine. Include documentation to mount and … #60
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An issue we discovered while integrating Abraham that could be rather common is that routes from integrated engines are appended to the app routes.
We have a catch-all route as the final directive that means routes appended via
Rails.application.routes.draw
become unreachable. In this instance the/abraham_histories
route was unreachable.This PR attempts to isolate and namespace Abraham so that it can be mounted separately.
Given the additional mounting requirement, the suggestion is that a major version is released.