Stop building utf8proc for distribution #1872
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
plajjan
force-pushed
the
ship-utf8proc-as-src
branch
4 times, most recently
from
ea6925b
to
ec89a51
Compare
Just ship the source code and instead let zigbuilder build it when needed. Also moves the dependency from the main build.zig to base's build.zig, which we can do now that we are relying entirely on the Zig style build and no manual linking of .a files, like we did before. Bump version of utf8proc to one with a newer build.zig that installs the header correctly and also has option for shared build (which we don't use).
plajjan
force-pushed
the
ship-utf8proc-as-src
branch
from
ec89a51
to
8d99344
Compare
|
Part of #1871. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just ship the source code and instead let zigbuilder build it when needed.
Also moves the dependency from the main build.zig to base's build.zig, which we can do now that we are relying entirely on the Zig style build and no manual linking of .a files, like we did before.
Bump version of utf8proc to one with a newer build.zig that installs the header correctly and also has option for shared build (which we don't use).