Ship libs as src and build on demand #1875
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It's only needed for actondb...
plajjan
force-pushed
the
zig-ng-build-libs
branch
from
c636eb8
to
af76997
Compare
RTS needs uuid
This way we can catch errors that otherwise only pop up when running tests natively on a particular platform.
Otherwise we might suck in a uuid.h header from the system but by specifying a target we get our own bundled libuuid (provided our build.zig is correct etc)
I think I've seen some concurrency issues in CI. That really shouldn't happen as actonc should already take a lock around everything.. maybe using `acton build` (which takes a lock of its own) improves things. Regardless, we really should strive towards calling `acton` rather than `actonc` anyway, since that is the primary frontend.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #1871