Simplify actor creation #3
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
(+) trait PropsConstructor (+) PropsConstructor implementation for all actors with impl Default (c) renamed actor_of to actor_of_props (+) implemented actor_of for structs which implement PropsConstructor (c) updated tests (c) updated readme
(c) rename ArgsPropsConstructor to ActorFactoryArgs (c) fixed tests
(c) changed test (which I missed earlier) to use the new actor_of
(c) removed ActorFactory (c) renamed ActorFactoryArgs to ActorFactory (c) changed impl ActorFactory for A: Default + Actor to work with the changed traits
This reverts commit 2326a93.
# Conflicts: # src/system/system.rs
…or "actor_of_args"
… only one impl per struct is possible
…tory and ActorFactoryArgs respectively fix spelling in README.md
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
taken from
riker-rs#84