-
Notifications
You must be signed in to change notification settings - Fork 168
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: error parameterisation (and assignment) for geometric digitisation #2815
feat: error parameterisation (and assignment) for geometric digitisation #2815
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2815 +/- ##
==========================================
- Coverage 49.10% 48.82% -0.28%
==========================================
Files 501 491 -10
Lines 29295 28886 -409
Branches 13906 13705 -201
==========================================
- Hits 14385 14104 -281
+ Misses 4956 4954 -2
+ Partials 9954 9828 -126 ☔ View full report in Codecov by Sentry. |
📊: Physics performance monitoring for 7d88d5cphysmon summary
|
Hi @asalzburger, I can review tomorrow most likely, fyi |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice one, @asalzburger! I have only minor comments. At some point this should be used for calibration as well, but ofc that can wait.
Invalidated by push of 821b3cc
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for taking my comments into account @asalzburger ! Looks good to go!
Co-authored-by: Andreas Stefl <stefl.andreas@gmail.com>
Invalidated by push of 2cfb7d6
Hey @gagnonlg - PR comments are addressed. Will ping you after python formatting is fixed. |
@asalzburger can you resolve the CI failures? |
Hey @andiwand - I finally got around fixing this. |
…ion (acts-project#2815) The geometric digitisation so far did set the pitch size `p/std::sqrt(12)` as an estimated error, but this is not correct, in general, it overestimates the variances. This PR introduces a python based script that runs on top of the `Example/Digitization` root output files and allows to parameterise the errors in given cluster sizes. ![Screenshot 2023-12-12 at 16 29 35](https://github.com/acts-project/acts/assets/26623879/1d96564e-dada-49e2-9f44-50238b821619) It will produce overview plots, a browsable HTML file and can be used to attach variance information to the `GeoDigiConf` which then are read in (`json` updated) and assigned (`DigitizationAlgorithm`) updated. ![Screenshot 2023-12-12 at 16 32 58](https://github.com/acts-project/acts/assets/26623879/33926c3c-d72d-445b-af7f-608752cc1ab0)
The geometric digitisation so far did set the pitch size
p/std::sqrt(12)
as an estimated error, but this is not correct, in general, it overestimates the variances.This PR introduces a python based script that runs on top of the
Example/Digitization
root output files and allows to parameterise the errors in given cluster sizes.It will produce overview plots, a browsable HTML file and can be used to attach variance information to the
GeoDigiConf
which then are read in (json
updated) and assigned (DigitizationAlgorithm
) updated.