Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: error parameterisation (and assignment) for geometric digitisation #2815

Merged

Conversation

asalzburger
Copy link
Contributor

The geometric digitisation so far did set the pitch size p/std::sqrt(12) as an estimated error, but this is not correct, in general, it overestimates the variances.

This PR introduces a python based script that runs on top of the Example/Digitization root output files and allows to parameterise the errors in given cluster sizes.

Screenshot 2023-12-12 at 16 29 35

It will produce overview plots, a browsable HTML file and can be used to attach variance information to the GeoDigiConf which then are read in (json updated) and assigned (DigitizationAlgorithm) updated.

Screenshot 2023-12-12 at 16 32 58

@asalzburger asalzburger added this to the next milestone Dec 12, 2023
@github-actions github-actions bot added the Component - Examples Affects the Examples module label Dec 12, 2023
Copy link

codecov bot commented Dec 12, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 48.82%. Comparing base (bdf9ae1) to head (858d551).
Report is 32 commits behind head on main.

❗ Current head 858d551 differs from pull request most recent head 7d88d5c. Consider uploading reports for the commit 7d88d5c to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2815      +/-   ##
==========================================
- Coverage   49.10%   48.82%   -0.28%     
==========================================
  Files         501      491      -10     
  Lines       29295    28886     -409     
  Branches    13906    13705     -201     
==========================================
- Hits        14385    14104     -281     
+ Misses       4956     4954       -2     
+ Partials     9954     9828     -126     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@gagnonlg
Copy link
Contributor

Hi @asalzburger, I can review tomorrow most likely, fyi

gagnonlg
gagnonlg previously approved these changes Dec 20, 2023
Copy link
Contributor

@gagnonlg gagnonlg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice one, @asalzburger! I have only minor comments. At some point this should be used for calibration as well, but ofc that can wait.

@acts-policybot acts-policybot bot dismissed gagnonlg’s stale review January 18, 2024 16:58

Invalidated by push of 821b3cc

gagnonlg
gagnonlg previously approved these changes Jan 19, 2024
Copy link
Contributor

@gagnonlg gagnonlg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for taking my comments into account @asalzburger ! Looks good to go!

Co-authored-by: Andreas Stefl <stefl.andreas@gmail.com>
@acts-policybot acts-policybot bot dismissed gagnonlg’s stale review January 23, 2024 05:57

Invalidated by push of 2cfb7d6

@asalzburger
Copy link
Contributor Author

asalzburger commented Jan 23, 2024

Hey @gagnonlg - PR comments are addressed. Will ping you after python formatting is fixed.

@github-actions github-actions bot added the Stale label Feb 28, 2024
@andiwand
Copy link
Contributor

andiwand commented Mar 1, 2024

@asalzburger can you resolve the CI failures?

@github-actions github-actions bot removed the Stale label Mar 1, 2024
@github-actions github-actions bot added the Stale label Apr 13, 2024
@github-actions github-actions bot removed the Stale label Apr 13, 2024
@asalzburger asalzburger requested a review from andiwand May 6, 2024 21:22
@asalzburger
Copy link
Contributor Author

Hey @andiwand - I finally got around fixing this.

@kodiakhq kodiakhq bot merged commit 666d7aa into acts-project:main May 7, 2024
53 checks passed
@github-actions github-actions bot removed the automerge label May 7, 2024
@acts-project-service acts-project-service added Breaks Athena build This PR breaks the Athena build Fails Athena tests This PR causes a failure in the Athena tests labels May 7, 2024
@andiwand andiwand modified the milestones: next, v35.0.0 May 17, 2024
asalzburger added a commit to asalzburger/acts that referenced this pull request May 21, 2024
…ion (acts-project#2815)

The geometric digitisation so far did set the pitch size `p/std::sqrt(12)` as an estimated error, but this is not correct, in general, it overestimates the variances.

This PR introduces a python based script that runs on top of the `Example/Digitization` root output files and allows to parameterise the errors in given cluster sizes.

![Screenshot 2023-12-12 at 16 29 35](https://github.com/acts-project/acts/assets/26623879/1d96564e-dada-49e2-9f44-50238b821619)

It will produce overview plots, a browsable HTML file and can be used to attach variance information to the `GeoDigiConf` which then are read in (`json` updated) and assigned (`DigitizationAlgorithm`) updated.

![Screenshot 2023-12-12 at 16 32 58](https://github.com/acts-project/acts/assets/26623879/33926c3c-d72d-445b-af7f-608752cc1ab0)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Breaks Athena build This PR breaks the Athena build Component - Examples Affects the Examples module Fails Athena tests This PR causes a failure in the Athena tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants