refactor: Unconditionally use blocked mult in EigenStepper

[paulgessinger]

Just to try if this also returns clean outputs, I'm downgrading the if added in #1181 to an assert. Let's see what the CI says here.

[codecov]

Codecov Report

Attention: Patch coverage is 0% with 10 lines in your changes are missing coverage. Please review.

Project coverage is 48.68%. Comparing base (2664480) to head (943fc2c).

Files	Patch %	Lines
Core/include/Acts/Propagator/EigenStepper.ipp	0.00%	0 Missing and 10 partials ⚠️

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #3009   +/-   ##
=======================================
  Coverage   48.67%   48.68%           
=======================================
  Files         493      493           
  Lines       29055    29052    -3     
  Branches    13853    13850    -3     
=======================================
  Hits        14143    14143           
+ Misses       4966     4965    -1     
+ Partials     9946     9944    -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[github-actions]

📊: Physics performance monitoring for 943fc2c

Full contents

physmon summary

• ✅ CKF truth_smeared
• ✅ IVF truth_smeared
• ✅ AMVF truth_smeared
• ✅ Track Summary CKF truth_smeared
• ✅ Seeding truth_estimated
• ✅ CKF truth_estimated
• ✅ IVF truth_estimated
• ✅ AMVF truth_estimated
• ✅ Track Summary CKF truth_estimated
• ✅ Seeding seeded
• ✅ CKF seeded
• ✅ IVF seeded
• ✅ AMVF seeded
• ✅ AMVF (+grid seeder) seeded
• ✅ Track Summary CKF seeded
• ✅ Seeding orthogonal
• ✅ CKF orthogonal
• ✅ IVF orthogonal
• ✅ AMVF orthogonal
• ✅ Track Summary CKF orthogonal
• ✅ Ambisolver seeded
• ✅ Ambisolver orthogonal
• ✅ Seeding ttbar
• ✅ CKF ttbar
• ✅ Ambisolver
• ✅ Track Summary CKF ttbar
• ✅ AMVF ttbar
• ✅ AMVF (+grid seeder) ttbar
• ✅ Truth tracking (GSF)
• ✅ Truth tracking
• ✅ Truth tracking (GX2F)
• ✅ Particles fatras
• ✅ Particles geant4

[paulgessinger]

All green, no output changes at all it seems.

Should we do this @stephenswat @andiwand ?

[stephenswat]

Nice!

@andiwand do you have any performance numbers for this?

[paulgessinger]

@stephenswat I can run a quick test.

[paulgessinger]

This is from 10 runs of ODD full chain without IO:

Looks pretty promising, I'm rerunning with a bit more stats.

[andiwand]

very interesting! I thought the assert would fire

[acts-project-service]

✅ Athena integration test results [f25a727]

✅ All tests successful

status	job	report
🟢	run_unit_tests
🟢	test_ActsEFTrackFit
🟢	test_ActsBenchmarkWithSpot
🟢	test_ActsConversionWorkflow
🟢	test_ActsWorkflow
🟢	test_ActsValidateAmbiguityResolution
🟢	test_ActsValidateResolvedTracks
🟢	test_ActsValidateTracks
🟢	test_ActsValidateActsCoreSpacePoints
🟢	test_ActsValidateActsSpacePoints
🟢	test_ActsValidateSeeds
🟢	test_ActsValidateOrthogonalSeeds
🟢	test_ActsValidateClusters
🟢	test_ActsPersistifyEDM
🟢	test_ActsGSFRefitting
🟢	test_ActsKfRefitting
🟢	test_ActsExtrapolationAlgTest
🟢	test_ActsITkTest
🟢	run_workflow_tests_run4_mc
🟢	run_workflow_tests_run2_mc
🟢	run_workflow_tests_run2_data
🟢	run_workflow_tests_run3_mc
🟢	run_workflow_tests_run3_data
🟢	run_art_test: test_data18_13TeV_1000evt
🟢	run_art_test: test_ttbarPU40_reco

[paulgessinger]

More stats seem to confirm the measurement from before, I think we're looking at about a 5% speedup.

[paulgessinger]

Athena is green now, should we get this in? @andiwand

[andiwand]

lets go