Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(gx2f): remove outdated navigation abort conditions #3552

Merged
merged 2 commits into from
Aug 26, 2024

Conversation

AJPfleger
Copy link
Contributor

Removes some unnecessary navigation limits from the GX2F.

if (result.processedMeasurements >= inputMeasurements->size()) {

Not necessary anymore, since we have the same limit already in the beginning of the actor.

if (result.surfaceCount > 900) {

This limit was set to abort the navigation, even if not all measurements have been found. The navigation in the GX2F is now stable enough, that we don't need this limit anymore

Copy link

github-actions bot commented Aug 26, 2024

📊: Physics performance monitoring for 3ad93bb

Full contents

physmon summary

@AJPfleger AJPfleger marked this pull request as ready for review August 26, 2024 12:22
Copy link

sonarcloud bot commented Aug 26, 2024

@kodiakhq kodiakhq bot merged commit 1b38338 into acts-project:main Aug 26, 2024
42 checks passed
@AJPfleger AJPfleger deleted the gx2f-limit branch August 26, 2024 18:22
@acts-project-service acts-project-service added the Fails Athena tests This PR causes a failure in the Athena tests label Aug 26, 2024
kodiakhq bot pushed a commit that referenced this pull request Aug 30, 2024
@andiwand andiwand modified the milestones: next, v36.3.0 Sep 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component - Core Affects the Core module Fails Athena tests This PR causes a failure in the Athena tests Track Fitting
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants