Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(gx2f): early exit for the Actor #3566

Merged
merged 7 commits into from
Aug 28, 2024

Conversation

AJPfleger
Copy link
Contributor

@AJPfleger AJPfleger commented Aug 27, 2024

The design for the Actor of the GX2F is clear now. Since we have only a clear forward propagation, we can skip all navigation states without a surface. Therefore, we do not need to reserve any options afterwards and early exits are possible.

@AJPfleger AJPfleger added this to the next milestone Aug 27, 2024
@github-actions github-actions bot added Component - Core Affects the Core module Track Fitting labels Aug 27, 2024
Copy link

github-actions bot commented Aug 27, 2024

📊: Physics performance monitoring for aab8ebd

Full contents

physmon summary

@AJPfleger AJPfleger marked this pull request as ready for review August 27, 2024 12:31
@andiwand
Copy link
Contributor

@AJPfleger there seems to be a failure in the gitlab ci

@AJPfleger
Copy link
Contributor Author

The gitlab CI failure seems unrelated to my changes:

🔴 CKF | trackfinding | ttbar with 200 pileup | default seeding

image

🔴 Ambisolver | trackfinding | ttbar with 200 pileup | default seeding

image
image

🔴 AMVF gauss notime | trackfinding | ttbar with 200 pileup | default seeding

image

I couldn't see it on main, let's see, if a rerun of the CI fixes it.

Copy link

sonarcloud bot commented Aug 28, 2024

@kodiakhq kodiakhq bot merged commit 468e937 into acts-project:main Aug 28, 2024
42 checks passed
@AJPfleger AJPfleger deleted the gx2f-actor-shift-more branch August 29, 2024 05:26
kodiakhq bot pushed a commit that referenced this pull request Aug 30, 2024
@andiwand andiwand modified the milestones: next, v36.3.0 Sep 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component - Core Affects the Core module Track Fitting
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants